Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCAL: fixing fine grain bits to be set based on unpacked TDC [12_3_X backport] #37307

Merged
merged 1 commit into from Mar 26, 2022

Conversation

gk199
Copy link
Contributor

@gk199 gk199 commented Mar 22, 2022

PR description:

Changes are made in HcalFinegrainBit.cc to have both HB and HE fine grain bits set based on unpacked TDC. The fine grain bit algorithm relies on trigger primitives, which are prior to where the HB TDC packing (6:2 bit LUT) is performed. The 6:2 packing occurs in PackerHelp.h (tdc1 and tdc2 implemented in https://cmssdt.cern.ch/lxr/source/EventFilter/HcalRawToDigi/plugins/PackerHelp.h). With the change, HB and HE rely on the same logic, using tdc_boundary to compare to the TDC values.

Variable name tdc_HE was changed to tdc_boundary to be more clear. This encodes the prompt – delayed boundaries for both HB and HE.

PR validation:

Tested in CMSSW_12_3_X_2022-03-21-1100. Passed runTheMatrix.py.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of PR #37302. Backporting to 12_3_X since this is where L1 emulator was merged (PR #36919), which relies on these fine grain bits downstream. Backporting is needed since L1 rates and menu testing of the new LLP trigger seeds are impacted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2022

A new Pull Request was created by @gk199 (Gillian Kopp) for CMSSW_12_3_X.

It involves the following packages:

  • SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9eeeb8/23308/summary.html
COMMIT: c4a5bf4
CMSSW: CMSSW_12_3_X_2022-03-22-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37307/23308/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695161
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695118
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #37302

@qliphy
Copy link
Contributor

qliphy commented Mar 26, 2022

+1

@cmsbuild cmsbuild merged commit 06e7c89 into cms-sw:CMSSW_12_3_X Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants