AllStepsToTree option switched ON #37329

conetthuerta · 2022-03-24T03:29:45Z

PR description:

~/CMSSW_12_3_X_2022-03-23-1100/src/Validation/Geometry/test/runP_Tracker.py is updated;

AllStepsToTree option has been fixed by "Fix AllStepsToTree option to runP_Tracker.py script Fix AllStepsToTree option to runP_Tracker.py script #37095"; this pull request puts AllStepsToTree option in use in runP_Tracker.py.
This PR depends on "Fix AllStepsToTree option to runP_Tracker.py script Fix AllStepsToTree option to runP_Tracker.py script #37095", and will depend on any PR's or externals that report a present/future problem/issue/improvement on the AllStepsToTree option.
AllStepsToTree option switched ON is necessary for MaterialBudget.py to generate a number of non-empty plots (see PR validation below).
Fix AllStepsToTree option to runP_Tracker.py script #37095

PR validation:

Tracker Material Budget Validation was run with CMSSW_12_3_X_2022-03-23-1100 (https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerMaterialBudgetValidation - TWiki needs to be updated), "Validation plots: single geometry configuration" were produced (.png and .pdf files that illustrate the tracker material budget, measured in fractional radiation lengths x or hadronic interaction lengths l, plotted as a function of eta, or phi, or R, or eta and phi, etc.).

Some "Validation plots: single geometry configuration" cannot be produced (MaterialBudget.py produces empty plots) when AllStepsToTree option is switched OFF in tested versions of CMSSW_12 - AllStepsToTree option switched ON is necessary.
Relevant TWiki page (needs to be updated): https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerMaterialBudgetValidation

log in to user@lxplus7.cern.ch (follow the usual steps on Terminal, see example at the end)
COPY-PASTE into terminal: {
tcsh
setenv SCRAM_ARCH slc7_amd64_gcc10
scram project CMSSW_12_3_X_2022-03-23-1100
cd CMSSW_12_3_X_2022-03-23-1100/src
cmsenv
git cms-addpkg Validation/Geometry
scram b disable-biglib
cmsenv
scram b -j8
cd Validation/Geometry/test
cmsRun single_neutrino_cfg.py
python3 runP_Tracker.py geom=Extended2017Plan1 label=Tracker > matbudget.out
cmsenv
mkdir Images
python3 MaterialBudget.py -s -d Tracker -g "Extended2017Plan1" # 's' means single and d means 'detector'
} END COPY-PASTE into terminal.

Instructions to log in to user@lxplus7.cern.ch

Enter the following line in your Terminal:

Enter your CERN password when prompted to do so,
Your terminal should now begin with (you have successfully logged in) :

[username@lxplus7## ~]$

if this PR is a backport please specify the original PR and why you need to backport that PR:

Fix AllStepsToTree option to runP_Tracker.py script #37095

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2022-03-24T03:41:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37329/28973

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add HLT75e33 step to Phase-2 workflows #37324

cmsbuild · 2022-03-24T03:42:04Z

A new Pull Request was created by @conetthuerta for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm (alca)
CUDADataFormats/CaloCommon (heterogeneous, reconstruction)
CUDADataFormats/HcalDigi (heterogeneous, reconstruction)
CUDADataFormats/HcalRecHitSoA (heterogeneous, reconstruction)
CUDADataFormats/StdDictionaries (heterogeneous)
CondTools/SiStrip (db)
Configuration/PyReleaseValidation (pdmv, upgrade)
DQM/BeamMonitor (dqm)
DQM/GEM (dqm)
DQM/Integration (dqm)
DQMOffline/L1Trigger (dqm, l1)
EventFilter/L1TRawToDigi (l1)
HLTrigger/Configuration (hlt)
HLTrigger/Muon (hlt)
L1Trigger/L1TNtuples (l1)
MuonAnalysis/MuonAssociators (analysis)
RecoTracker/MkFit (reconstruction)
RecoTracker/MkFitCMS (reconstruction)
RecoTracker/MkFitCore (reconstruction)
SimG4CMS/Calo (simulation)
Utilities/StorageFactory (core)
Validation/Geometry (geometry, dqm)
Validation/MuonCSCDigis (dqm)

@bbilin, @wajidalikhan, @ianna, @Martin-Grunewald, @jpata, @santocch, @cecilecaillol, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @fwyzard, @pmandrik, @smuzaffar, @Dr15Jones, @epalencia, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @slava77, @ggovi, @pbo0, @francescobrivio, @malbouis, @jordan-martins, @rekovic, @clacaputo, @srimanob, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@jhgoh, @felicepantaleo, @abbiendi, @kpedro88, @Martin-Grunewald, @bsunanda, @wddgit, @thomreis, @tlampen, @missirol, @rishabhCMS, @threus, @mmusich, @slomeo, @kreczko, @HuguesBrun, @battibass, @makortel, @JanFSchulte, @watson-ij, @dgulhan, @apsallid, @sscruz, @CeliaFernandez, @simonepigazzini, @rbartek, @trocino, @rociovilar, @cvuosalo, @GiacomoSguazzoni, @rovere, @eyigitba, @bellan, @tocheng, @ebrondol, @VinInn, @mtosi, @fabiocos, @francescobrivio, @batinkov, @adewit, @vargasa, @Fedespring, @calderona, @silviodonato, @lecriste, @dinyar, @gpetruc, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

srimanob · 2022-03-24T03:44:34Z

Should rebase first?

jpata · 2022-03-24T09:52:51Z

-reconstruction

needs a rebase
e7c78d2 is not reco-related

Martin-Grunewald · 2022-03-24T13:20:41Z

-1
rebase needed
(to remove from hlt queue)

cmsbuild · 2022-03-24T14:07:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37329/28984

This PR adds an extra 16KB to repository

cmsbuild · 2022-03-24T14:07:48Z

Pull request #37329 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @emanueleusai, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

cvuosalo · 2022-03-24T14:41:21Z

+1

jfernan2 · 2022-03-24T16:43:29Z

+1

cmsbuild · 2022-03-24T16:45:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-03-24T22:17:06Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5b901/23359/summary.html
COMMIT: 402002b
CMSSW: CMSSW_12_4_X_2022-03-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37329/23359/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx301 Use messagelogger service instead of cout #37297

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5b901/23359/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5b901/23359/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3331 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 49948
DQMHistoTests: Total nulls: 66
DQMHistoTests: Total successes: 3645614
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

qliphy · 2022-03-25T00:41:17Z

please test

cmsbuild · 2022-03-25T08:14:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5b901/23372/summary.html
COMMIT: 402002b
CMSSW: CMSSW_12_4_X_2022-03-24-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37329/23372/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3360 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 49954
DQMHistoTests: Total nulls: 66
DQMHistoTests: Total successes: 3645608
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2022-03-25T13:38:33Z

+1

perrotta · 2022-03-25T13:50:20Z

ping bot

cmsbuild added this to the CMSSW_12_4_X milestone Mar 24, 2022

cmsbuild added alca-pending analysis-pending code-checks-pending core-pending db-pending dqm-pending geometry-pending heterogeneous-pending hlt-pending l1-pending orp-pending pdmv-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Mar 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 24, 2022

cmsbuild mentioned this pull request Mar 24, 2022

Add HLT75e33 step to Phase-2 workflows #37324

Merged

cmsbuild added reconstruction-rejected and removed reconstruction-pending labels Mar 24, 2022

AllStepsToTree switched ON

402002b

conetthuerta force-pushed the AllStepsToTree_switched_ON branch from e7c78d2 to 402002b Compare March 24, 2022 14:00

cmsbuild added the code-checks-pending label Mar 24, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 24, 2022

cmsbuild added geometry-approved tests-started and removed geometry-pending tests-pending labels Mar 24, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 24, 2022

cmsbuild added tests-rejected and removed tests-started labels Mar 24, 2022

cmsbuild added tests-started and removed tests-rejected labels Mar 25, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 25, 2022

cmsbuild added orp-approved and removed orp-pending labels Mar 25, 2022

cmsbuild merged commit 48409a2 into cms-sw:master Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AllStepsToTree option switched ON #37329

AllStepsToTree option switched ON #37329

conetthuerta commented Mar 24, 2022 •

edited

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

srimanob commented Mar 24, 2022

jpata commented Mar 24, 2022

Martin-Grunewald commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cvuosalo commented Mar 24, 2022

jfernan2 commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

qliphy commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

Navigation Menu

AllStepsToTree option switched ON #37329

AllStepsToTree option switched ON #37329

Conversation

conetthuerta commented Mar 24, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

srimanob commented Mar 24, 2022

jpata commented Mar 24, 2022

Martin-Grunewald commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cvuosalo commented Mar 24, 2022

jfernan2 commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

cmsbuild commented Mar 24, 2022

RelVals-INPUT

Comparison Summary

qliphy commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

Comparison Summary

perrotta commented Mar 25, 2022

perrotta commented Mar 25, 2022

conetthuerta commented Mar 24, 2022 •

edited