Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X + Update of L1T menu in TSG GTs [12_4_X] #37338

Merged
merged 2 commits into from Mar 25, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_3_X + Update of L1T menu in TSG GTs to L1Menu_Collisions2022_v0_1_8_xml.

This is the PR for the master branch, which will then be backported to 12_3_X (which is currently the release used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2245: introduction of Dataset Paths (and FinalPaths).

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@missirol
Copy link
Contributor Author

This is the PR for the master branch, which will then be backported to 12_3_X (which is currently the release used for HLT-menu development for Run 3).

@perrotta @qliphy (just as a general clarification)

As discussed offline and briefly in the last ORP, TSG is keeping the development of Run-3 HLT menus in 12_3_X for now.

In the next weeks, we will have PRs for "HLT menu development for 12_3_X" first opened for master (12_4_X), and then backported to 12_3_X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37338/28986

  • This PR adds an extra 804KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd3c30/23363/summary.html
COMMIT: 5a9e1bc
CMSSW: CMSSW_12_4_X_2022-03-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37338/23363/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3525 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695644
  • DQMHistoTests: Total failures: 50722
  • DQMHistoTests: Total nulls: 56
  • DQMHistoTests: Total successes: 3644844
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.096 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.516 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 25, 2022

+1

@cmsbuild cmsbuild merged commit a9e347f into cms-sw:master Mar 25, 2022
@missirol missirol deleted the HLTdevelopment123X_for124X branch March 27, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants