Run-3 FastSim modifier and workflows in runTheMatrix #37347

srimanob · 2022-03-25T16:09:00Z

PR description:

As reported in SIM meeting news (25 March), https://indico.cern.ch/event/1143277/, FastSim cmsDriver does not work. This PR is to handle Run-3 FastSim workflow including

fix the issue coming from the interplay between run3_common and fastSim modifiers.
include PAT step to the FastSim sequence as done in the FullSim. The MINIAODMCUPXXFS step is not needed at the end of sequence.
introduce 2021 FastSim (NoPU and MinBias FASTPU for mixing) workflows in upgrade style.

Topic to discuss (maybe at the later PR):

It is not clear we should exclude GEM also as we did for Run-2. I just create FastSim era in the same way as Run_2 by excluding it. It may not need to exclude anymore.
Handle premixing wf in upgrade

Issues (keep track in #37351):

Currently, Workflows run upto PAT. However, the validation, dqm and harvesting are not yet done for miniaod.
Nano does not work.

PR validation:

Configs from following runTheMatrix run until the end.
runTheMatrix.py --what upgrade -l 11634.301,11640.303 -t 8 --wm init

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no need of backport

srimanob · 2022-03-25T16:09:25Z

FYI @civanch @sbein

srimanob · 2022-03-25T16:16:11Z

Hi @kpedro88

When we set a parameter to None, we can't set it to None again?
run3_common.toModify(simCastorDigis, mix = None)
can't follow with
fastSim.toModify(simCastorDigis, mix = None)

After I add ~run3_common to fastSim, it works again.

Thanks for suggestion.

cmsbuild · 2022-03-25T16:16:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37347/28998

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

cmsbuild · 2022-03-25T16:18:18Z

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/StandardSequences (operations)
SimGeneral/MixingModule (simulation)

@perrotta, @civanch, @mdhildreth, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2022-03-25T16:39:36Z

That's correct. I think (fastSim & ~run3_common) is the right way to handle this case.

sbein · 2022-03-25T18:43:15Z

Thanks @srimanob. Can I ask what is the point of "copy" in the copyAndExclude function

Run3_FastSim = Run3.copyAndExclude([run3_GEM])

? Will this essentially negate all of the modification statements associated with run3_GEM? I guess this is the standard way to exclude a sub-detector? On a side note, maybe something similar could be used to get around the missing HGCal information issue while developing the phase 2 fastsim tracker implementation.

kpedro88 · 2022-03-25T18:45:56Z

copyAndExclude copies all the modifiers and chains in the Run3 Era, except for the list provided as an argument, which are excluded. Yes, this is the standard way to drop a subdetector or other modifier that is not appropriate for an Era.

cmsbuild · 2022-03-25T19:08:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37347/29001

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 #37345
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add HLT75e33 step to Phase-2 workflows #37324, Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 #37345
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

cmsbuild · 2022-03-25T19:08:50Z

Pull request #37347 was updated. @perrotta, @civanch, @jordan-martins, @bbilin, @wajidalikhan, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

srimanob · 2022-03-25T19:11:44Z

test parameters:

workflows = 2021.1,2021.8
relvals_opt = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix

srimanob · 2022-03-25T19:12:24Z

@cmsbuild please test

srimanob · 2022-03-25T19:21:02Z

Note to @cms-sw/dqm-l2

Could you please advise on validation, dqm, and harvesting sequences to be used with FastSim? The following test does not work. It can come in later PR. I've opened the issue to follow up #37351
Thanks.

cmsDriver:
cmsDriver.py TTbar_14TeV_TuneCP5_cfi --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQMFS+@miniAODDQM -n 10 --conditions auto:phase1_2021_realistic --beamspot Run3RoundOptics25ns13TeVLowSigmaZ --datatier GEN-SIM-DIGI-RECO,MINIAODSIM,DQMIO --eventcontent FEVTDEBUGHLT,MINIAODSIM,DQM --fast --era Run3_FastSim --io TTbarFS_14_UP21.io --python TTbarFS_14_UP21.py --no_exec --fileout file:step1.root --nThreads 8

Error:

GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,PAT,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQMFS+@miniAODDQM
We have determined that this is simulation (if not, rerun cmsDriver.py with --data)
Step: GEN Spec: 
Loading generator fragment from Configuration.Generator.TTbar_14TeV_TuneCP5_cfi
Step: SIM Spec: 
Step: RECOBEFMIX Spec: 
Step: DIGI Spec: ['pdigi_valid']
Step: L1 Spec: 
Step: DIGI2RAW Spec: 
Step: L1Reco Spec: 
Step: RECO Spec: 
Step: PAT Spec: 
Step: VALIDATION Spec: ['@standardValidation', '@miniAODValidation']
@standardValidation+@miniAODValidation in preparing validation
Step: DQM Spec: ['@standardDQMFS', '@miniAODDQM']
Traceback (most recent call last):
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_0_pre1/bin/slc7_amd64_gcc10/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_0_pre1/bin/slc7_amd64_gcc10/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_0_pre1/python/Configuration/Applications/ConfigBuilder.py", line 2162, in prepare
    self.addStandardSequences()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_0_pre1/python/Configuration/Applications/ConfigBuilder.py", line 790, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = '+'.join(stepSpec))
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_4_0_pre1/python/Configuration/Applications/ConfigBuilder.py", line 1993, in prepare_DQM
    setattr(self.process,pathName, cms.EndPath( getattr(self.process,sequence ) ) )
AttributeError: 'Process' object has no attribute 'DQMOfflineMiniAOD'

srimanob · 2022-03-29T10:49:41Z

@cmsbuild please test

The last error does not relate to the PR. Two Run-3 fastsim workflows, 11634.301 and 11640.303, run fine.

cmsbuild · 2022-03-29T18:08:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7af869/23491/summary.html
COMMIT: dbfb6ff
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37347/23491/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7af869/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-7af869/11640.303_MinBias_14TeV+2021_Run3FSMBMixing+MinBias_14TeV_pythia8_TuneCP5_GenSim

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3585896
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3585854
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

srimanob · 2022-03-30T04:17:09Z

+Upgrade

This PR fixes the fastsim sequence for Run-3 and add the wfs to run TheMatrix. @sbein Could you please re-sign. However, CMSSW_12_4_0_pre2 is built, so we will need to wait until pre3 to ask for FastSim relvals.

sbein · 2022-03-30T06:58:38Z

Thanks Phat +1

sbein · 2022-03-30T06:59:09Z

+1

civanch · 2022-03-31T07:47:45Z

+1

srimanob · 2022-04-04T06:47:53Z

Kindly ping @cms-sw/pdmv-l2

kskovpen · 2022-04-04T07:41:45Z

+pdmv

qliphy · 2022-04-05T01:22:44Z

+1

cmsbuild · 2022-04-05T01:23:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_12_4_X milestone Mar 25, 2022

cmsbuild added code-checks-pending operations-pending orp-pending pending-signatures simulation-pending tests-pending labels Mar 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 25, 2022

cmsbuild added code-checks-pending pdmv-pending upgrade-pending and removed code-checks-approved labels Mar 25, 2022

srimanob changed the title ~~[Draft/Not to merge] To make FastSim work for Run-3~~ Run-3 FastSim Mar 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 25, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 25, 2022

cmsbuild added tests-started and removed tests-rejected labels Mar 29, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 29, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Mar 30, 2022

cmsbuild mentioned this pull request Mar 30, 2022

Update all GPU workflows #37411

Merged

cmsbuild added simulation-approved and removed simulation-pending labels Mar 31, 2022

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 4, 2022

cmsbuild mentioned this pull request Apr 4, 2022

Dynamic Reduction Network for photon energy regression in miniAOD using the SonicTriton service #37134

Merged

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending pending-signatures orp-pending labels Apr 5, 2022

cmsbuild merged commit f9eea94 into cms-sw:master Apr 5, 2022

srimanob mentioned this pull request Jul 14, 2022

Add miniAODDQM FastSim Validation #38736

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run-3 FastSim modifier and workflows in runTheMatrix #37347

Run-3 FastSim modifier and workflows in runTheMatrix #37347

srimanob commented Mar 25, 2022 •

edited

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

kpedro88 commented Mar 25, 2022

sbein commented Mar 25, 2022

kpedro88 commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022 •

edited

srimanob commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

srimanob commented Mar 30, 2022

sbein commented Mar 30, 2022

sbein commented Mar 30, 2022

civanch commented Mar 31, 2022

srimanob commented Apr 4, 2022

kskovpen commented Apr 4, 2022

qliphy commented Apr 5, 2022

cmsbuild commented Apr 5, 2022

Run-3 FastSim modifier and workflows in runTheMatrix #37347

Run-3 FastSim modifier and workflows in runTheMatrix #37347

Conversation

srimanob commented Mar 25, 2022 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

kpedro88 commented Mar 25, 2022

sbein commented Mar 25, 2022

kpedro88 commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

cmsbuild commented Mar 25, 2022

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022

srimanob commented Mar 25, 2022 • edited

srimanob commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

Comparison Summary

srimanob commented Mar 30, 2022

sbein commented Mar 30, 2022

sbein commented Mar 30, 2022

civanch commented Mar 31, 2022

srimanob commented Apr 4, 2022

kskovpen commented Apr 4, 2022

qliphy commented Apr 5, 2022

cmsbuild commented Apr 5, 2022

srimanob commented Mar 25, 2022 •

edited

srimanob commented Mar 25, 2022 •

edited