Phase-2 L1: code for L1 demonstrators #37355

cecilecaillol · 2022-03-26T08:25:07Z

PR description:

This is the 2nd PR to port all L1T Phase-2 developments to cms-sw. This PR targets the demonstrator tools for the L1 boars. It includes several PRs made locally, the details of which can be found in the twiki https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideL1TPhase2Instructions and in the cms-l1t-offline branch.

cmsbuild · 2022-03-26T08:31:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37355/29006

This PR adds an extra 32KB to repository

cmsbuild · 2022-03-26T08:31:43Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

L1Trigger/DemonstratorTools (****)

The following packages do not have a category, yet:

L1Trigger/DemonstratorTools
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2022-03-26T08:31:59Z

please test

cmsbuild · 2022-03-26T13:10:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee0d4d/23407/summary.html
COMMIT: ab7bc43
CMSSW: CMSSW_12_4_X_2022-03-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37355/23407/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3582 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3695650
DQMHistoTests: Total failures: 49946
DQMHistoTests: Total nulls: 61
DQMHistoTests: Total successes: 3645621
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-03-29T12:06:27Z

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:
* L1Trigger/DemonstratorTools (****)
The following packages do not have a category, yet:

L1Trigger/DemonstratorTools Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol this is something you requested to watch as well. @perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

The new package was added to categories_map but it is not reflected in the flag here (new-package-pending)

cmsbuild · 2022-03-29T12:06:46Z

Pull request #37355 was updated. @epalencia, @rekovic, @cecilecaillol can you please check and sign again.

cecilecaillol · 2022-03-29T12:07:41Z

+l1

cmsbuild · 2022-03-29T12:08:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cecilecaillol · 2022-03-31T07:48:53Z

@perrotta, @dpiparo, @qliphy Could you please review this PR? Our next PRs rely on this code

perrotta · 2022-03-31T10:43:35Z

L1Trigger/DemonstratorTools/plugins/GTTFileReader.cc

+
+  l1t::VertexWordCollection vertices(decodeVertices(eventData.at({"vertices", 0})));
+
+  std::cout << vertices.size() << " vertices found" << std::endl;


cout should not be used in multithreaded runs, move to MessageLogger instead

perrotta · 2022-03-31T12:05:56Z

L1Trigger/DemonstratorTools/plugins/GTTFileReader.cc

+  //The following says we do not know what parameters are allowed so do no validation
+  // Please change this to state exactly what you do use, even if it is no parameters
+  edm::ParameterSetDescription desc;
+  desc.setUnknown();


You have only two parameters: please allow real parameter description and validation here

perrotta · 2022-03-31T12:07:47Z

L1Trigger/DemonstratorTools/plugins/GTTFileWriter.cc

+  //The following says we do not know what parameters are allowed so do no validation
+  // Please change this to state exactly what you do use, even if it is no parameters
+  edm::ParameterSetDescription desc;
+  desc.setUnknown();


Please allow real parameter description and validation here

cmsbuild · 2022-04-01T10:33:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37355/29126

This PR adds an extra 36KB to repository

cmsbuild · 2022-04-01T10:34:16Z

Pull request #37355 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

cecilecaillol · 2022-04-01T10:49:00Z

please test

cmsbuild · 2022-04-01T14:39:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee0d4d/23600/summary.html
COMMIT: 604d263
CMSSW: CMSSW_12_4_X_2022-03-31-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37355/23600/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3593039
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3593009
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 45 edm output root files, 48 DQM output files
TriggerResults: no differences found

cecilecaillol · 2022-04-01T15:41:59Z

+l1

cmsbuild · 2022-04-01T15:42:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-04-01T17:08:25Z

+1

add L1 demonstrator tools

ab7bc43

cmsbuild added this to the CMSSW_12_4_X milestone Mar 26, 2022

cmsbuild added code-checks-pending new-package-pending orp-pending pending-signatures tests-pending labels Mar 26, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 26, 2022

cmsbuild added l1-pending and removed new-package-pending labels Mar 29, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Mar 29, 2022

perrotta reviewed Mar 31, 2022

View reviewed changes

implement perrotta's comments

604d263

cmsbuild added code-checks-pending l1-pending pending-signatures tests-pending and removed l1-approved fully-signed tests-approved code-checks-approved labels Apr 1, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 1, 2022

cmsbuild added tests-started and removed tests-pending labels Apr 1, 2022

cmsbuild added tests-approved and removed tests-started labels Apr 1, 2022

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Apr 1, 2022

cmsbuild added orp-approved and removed orp-pending labels Apr 1, 2022

cmsbuild merged commit 2563e91 into cms-sw:master Apr 1, 2022

cecilecaillol deleted the port-l1tphase2-v2-124 branch June 13, 2022 12:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase-2 L1: code for L1 demonstrators #37355

Phase-2 L1: code for L1 demonstrators #37355

cecilecaillol commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cecilecaillol commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cecilecaillol commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

cecilecaillol commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

cecilecaillol commented Mar 31, 2022

perrotta Mar 31, 2022

perrotta Mar 31, 2022

perrotta Mar 31, 2022

cmsbuild commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

cecilecaillol commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

cecilecaillol commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

perrotta commented Apr 1, 2022


		l1t::VertexWordCollection vertices(decodeVertices(eventData.at({"vertices", 0})));

		std::cout << vertices.size() << " vertices found" << std::endl;

Navigation Menu

Phase-2 L1: code for L1 demonstrators #37355

Phase-2 L1: code for L1 demonstrators #37355

Conversation

cecilecaillol commented Mar 26, 2022

PR description:

cmsbuild commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

cecilecaillol commented Mar 26, 2022

cmsbuild commented Mar 26, 2022

Comparison Summary

cecilecaillol commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

cecilecaillol commented Mar 29, 2022

cmsbuild commented Mar 29, 2022

cecilecaillol commented Mar 31, 2022

perrotta Mar 31, 2022

Choose a reason for hiding this comment

perrotta Mar 31, 2022

Choose a reason for hiding this comment

perrotta Mar 31, 2022

Choose a reason for hiding this comment

cmsbuild commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

cecilecaillol commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

Comparison Summary

cecilecaillol commented Apr 1, 2022

cmsbuild commented Apr 1, 2022

perrotta commented Apr 1, 2022