Change quality criteria for some supercrystals in the Ecal Endcaps for LED Quality plots [Master]

[abhih1]

PR description:

This PR is done to modify the quality criteria of a few Supercrystals/Towers in DQM LED quality plots of the ECAL Endcaps. This set of supercrystals are known to be problematic by the ECAL LED experts and are being monitored. However it does not affect the quality of physics data and so in order to avoid the DQM displaying them as BAD constantly the quality criteria for them are being changed. The list of supercrystals tower ids are stored in the data file SClist.dat

PR validation:

This PR was validated by running the Standard Ecal calibration workflow on a test run and observing the DQM output file on an offline DQM test gui to confirm the code changes work as expected. The plots were also approved by the ECAL LED expert.
The PR was also validated by running the DQM relval workflow 136.874 using the runTheMatrix script
runTheMatrix.py -l 136.874 --ibeos

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37378/29031

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for master.

It involves the following packages:

• DQM/EcalMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test with cms-data/DQM-EcalMonitorClient#2

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6731e3/23485/summary.html
COMMIT: d9f03c2
CMSSW: CMSSW_12_4_X_2022-03-28-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37378/23485/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-tsg-storm HLT menu development for 12_3_X [12_4_X] #37370
• @VinInn Patatrack: introduce pt-clamping in vertex sorting, add #tracks in track SOA #37281
• @Dr15Jones Make JobReport::reportReadBranches thread safe #37364
• @francescobrivio Fix tag names in DQM Fake BeamSpot clients #37376
• @bsunanda Run3-124D Try to remove compilation warnings in L1Trigger/L1THGCalUtilities #37354
• @francescobrivio Add relval wf 139.005 to test the AlcaEcalPhiSym workflow for Run3 #37345
• @jeongeun Clean up redundant edm ParameterSet existAs or exist in RecoMET #37313
• @bsunanda Phase2-hgx302A Use MessageLogger instead of cout in a number of analyzers in HGCalGeometry #37312
• @apsallid update modifier to V16 #37366
• @bsunanda Phase2-hgx302B Use MessageLogger for cout in the second set of Analyzers in HGCalGeometry #37321
• @fwyzard Update hwloc to version 2.7.1 cmsdist#7714

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6731e3/23485/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6731e3/23485/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3583670
• DQMHistoTests: Total failures: 20149
• DQMHistoTests: Total nulls: 333
• DQMHistoTests: Total successes: 3563166
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1328.2459999999992 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 1461.475 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 1.887 KiB HLT/Filters
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 39434.0,... ): -2527.102 KiB HGCAL/HGCalValidator
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

please test with cms-data/DQM-EcalMonitorClient#2
Retriggering the tests to get a clean comparison

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6731e3/23516/summary.html
COMMIT: d9f03c2
CMSSW: CMSSW_12_4_X_2022-03-29-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37378/23516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3585896
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3585860
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Backport tested in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

ping bot