Run3-gex126A Try to resolve compilation warnings in RecoParticleFlow/PFProducer

[bsunanda]

PR description:

Try to resolve compilation warnings in RecoParticleFlow/PFProducer

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37399/29059

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37399/29059/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37399/29059/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37399/29063

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• RecoParticleFlow/PFProducer (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @seemasharmafnal, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6e693/23499/summary.html
COMMIT: 525ffae
CMSSW: CMSSW_12_4_X_2022-03-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37399/23499/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3585896
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3585866
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jpata]

Are these modules in /test/ in fact abandoned? I can't tell if they are being called anywhere. @laurenhay @cms-sw/pf-l2.

@bsunanda were you able to test the changes (beyond the fact that it compiles)?

[bsunanda]

@jpata I came across this compilation warning while I was editing a Geometry package and did checkdeps and build. It is annoying to see compilation warning. So I fixed it so that the warning goes away. I did not bother to test its functionality. Just ran the standard tests which may or may not cover this. If you think these corrections are redundant I can delete those classes. But I thought it is safer to remove the warnings and let others decide about the future of these classes

[laurenhay]

When you say runTheMatrix tests do you mean:
runTheMatrix.py -l limited -i all --ibeos
or something custom? Do you have what the warnings were when compiling?
Like Joosep said I don't see anything actually calling these test classes other than the build file. Asking around now about whether they're deprecated.

[jpata]

@laurenhay did you get any feedback from the groups if this code is still used?

[laurenhay]

@jpata Yes I asked around and as far as anyone knows in PF it is not being used. We think it's safe to remove these from the repository (of course they'll still exist in version control in the event a user of the code materializes).

[hatakeyamak]

Thank you @laurenhay. Just adding that I haven't seen these being used either.

[bsunanda]

@jpata @laurenhay @hatakeyamak So instead of fixing the two classes, let me then delete them in this PR. Hope you agree

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37399/29375

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • RecoParticleFlow/Configuration/test/RecoToDisplay_batch_cfg.py:
    • Deleted: 1cc6b5f
    • Added: af84bf6
  • RecoParticleFlow/PFProducer/test/particleFlowCandidateChecker_cfi.py:
    • Deleted: 1cc6b5f
    • Added: af84bf6

[cmsbuild]

Pull request #37399 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6e693/23983/summary.html
COMMIT: af84bf6
CMSSW: CMSSW_12_4_X_2022-04-18-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37399/23983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589907
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• on top of Run3-gex126A Try to resolve compilation warnings in RecoParticleFlow/PFProducer #37399 (comment), some additional cleanup
• I'm not sure if RecoToDisplay_*.py are really used, so we'll engage the PF group to further clean up the test code in a follow-up

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[jpata]

type pf

[perrotta]

+1