Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed overlaps in M10 Phase2 Scenario (D86, D88, D91) #37431

Merged
merged 1 commit into from Apr 2, 2022

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Apr 1, 2022

PR description:

Fixed all the overlaps in the Muon Yoke for M10 Phase2 Scenario (D86, D88, D91)

FYI: @srimanob

PR validation:

validation by "nohup cmsRun SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck2026_cfg.py >& overlaps.out &"
I set tolerance equal to 0.00001 to find nm overlaps.

Muon's volumes are not present in the overlaps.out file.

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37431/29124

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/MuonCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@missirol, @vargasa, @kpedro88, @Martin-Grunewald, @bsunanda, @ptcox, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Apr 1, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41b0a3/23597/summary.html
COMMIT: bc26b05
CMSSW: CMSSW_12_4_X_2022-03-31-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37431/23597/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7181 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 107482
  • DQMHistoTests: Total nulls: 76
  • DQMHistoTests: Total successes: 3485459
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 1, 2022

Comparison differences in the D88 workflows are expected since the geometry has slightly changed.

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 1, 2022

+1

@srimanob
Copy link
Contributor

srimanob commented Apr 2, 2022

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 2, 2022

+1

@cmsbuild cmsbuild merged commit 1d28ae9 into cms-sw:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants