[Backport of] HCAL finegrain bit fix to account for TDC packing, and SOI alignment

[gk199]

PR description:

HcalFinegrainBit.cc is run in cases where HB TDC is compressed and uncompressed. This PR handles both cases. In HcalTriggerPrimitiveAlgo.cc, frame.flavor() is used to define is_compressed which is passed to HcalFinegrainBit.cc. This determines if the input TDC values are uncompressed (flavor=0, is_compressed=0) or compressed (flavor=3, is_compressed=1). Depending on the TDC packing, either a comparison to tdc_boundary is made (uncompressed), or a direct comparison to TDC 0, 1, 2 is made.

Additional edits in HcalTriggerPrimitiveAlgo.cc are made to handle the matching of TP SOI and digi SOI in a more robust way. This ensures that with changes in conditions or filterPresamples, the TDC from the QIE11 dataframe SOI is selected for the fine grain bit algorithm SOI (ensuring ibin = 2 corresponds to idx = 5).

PR validation:

runTheMatrix.py passed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of PR #37438 to 123X, as the L1 LLP trigger emulator was merged in 123X (PR #36919) and relies upon the fine grain bits.

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for CMSSW_12_3_X.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL finegrain bit fix to account for TDC packing, and SOI alignment #37438

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-08b3f4/23634/summary.html
COMMIT: 25a9a7d
CMSSW: CMSSW_12_3_X_2022-04-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37439/23634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3697381
• DQMHistoTests: Total failures: 31
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697328
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cecilecaillol]

@perrotta, @dpiparo, @qliphy Is it possible to get this pr in before 12_3_0 is built? Thank you!

[qliphy]

@perrotta, @dpiparo, @qliphy Is it possible to get this pr in before 12_3_0 is built? Thank you!

@cecilecaillol The master PR was merged hrs ago. Once the master IB comes out and everything looks ok, we will proceed with this backport.

[cecilecaillol]

great, thank you!

[perrotta]

backport of #37438

[perrotta]

+1

• Verbatim backport of HCAL finegrain bit fix to account for TDC packing, and SOI alignment #37438