Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X #37475

Merged
merged 1 commit into from Apr 7, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Apr 6, 2022

backport of #37474

PR description:

Development of HLT menus for CMSSW_12_3_X.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2244: [TSG] Replace PFJetsMatchedToFilteredCaloJetsProducer by HLTPFJetsMatchedToFilteredCaloJetsProducer.
  • CMSHLT-2252: [MUO] Update of muon isolation for Run 3.
  • CMSHLT-2259: [TAU,EXO] Bugfix for dxy cut in displaced-tau trigger.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37474

Development of HLT menus for Run-3 startup.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Apr 6, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2de3df/23675/summary.html
COMMIT: 041b22f
CMSSW: CMSSW_12_3_X_2022-04-05-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37475/23675/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4002.04002.0_ZEE+ZEEINPUT+DIGI+RECO/step2_ZEE+ZEEINPUT+DIGI+RECO.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697375
  • DQMHistoTests: Total failures: 142
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

@missirol
Copy link
Contributor Author

missirol commented Apr 6, 2022

+hlt

  • the RelVals-INPUT error must be unrelated to this PR
  • differences in outputs of Run-3 wfs are compatible with the changes to the GRun HLT menu

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2de3df/23713/summary.html
COMMIT: 041b22f
CMSSW: CMSSW_12_3_X_2022-04-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37475/23713/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697375
  • DQMHistoTests: Total failures: 152
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697200
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 48 workflows

@Martin-Grunewald
Copy link
Contributor

urgent

@Martin-Grunewald
Copy link
Contributor

relval input tests now pass

@cmsbuild cmsbuild added the urgent label Apr 7, 2022
@Martin-Grunewald
Copy link
Contributor

@perrotta @qliphy
Please merge for 12_3_0

@perrotta
Copy link
Contributor

perrotta commented Apr 7, 2022

+1

  • Same HLT menu as the one already merged in master

@cmsbuild cmsbuild merged commit 4bb166f into cms-sw:CMSSW_12_3_X Apr 7, 2022
@missirol missirol deleted the HLTdevelopment123X branch April 7, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants