Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skim for Delayed Jets and DTClusters #37509

Merged
merged 1 commit into from Apr 16, 2022

Conversation

rtschmitz
Copy link

PR description:

This PR adds two RECO level skims that save all standard AOD collections. The delayed jet skim is for use in analyses using jet timing, such as EXO-19-001 (which requires collections only available at AOD). The DT cluster skim is for use in analyses using muon clusters, such as EXO-21-008. The DT cluster skim saves the following collections in addition to AOD:
DTLayerIdDTRecHit1DPairsOwnedRangeMap_dt1DRecHits__RECO
CSCDetIdCSCRecHit2DsOwnedRangeMap_csc2DRecHits__RECO

The delayed jet skim cuts on all tracks satisfying the associated HLT paths under "HLT_HT430_DelayedJet40*":
HLT_HT430_DelayedJet40_SingleDelay2nsInclusive_v1
HLT_HT430_DelayedJet40_DoubleDelay1nsInclusive_v1
HLT_HT430_DelayedJet40_SingleDelay1nsTrackless_v1
HLT_HT430_DelayedJet40_DoubleDelay0p5nsTrackless_v1

The DT cluster skim also cuts on tracks satisfying its associated HLT paths under "DTCluster":
HLT_L1MET_DTClusterNoMB1S50_v1
HLT_CaloMET60_DTClusterNoMB1S50_v1
HLT_L1MET_DTCluster50_v1
HLT_CaloMET60_DTCluster50_v1

Tested with a high-Pt QCD sample /store/relval/CMSSW_12_3_0_pre6/RelValQCD_Pt_1800_2400_14/GEN-SIM-RECO/123X_mcRun3_2021_realistic_v11-v2/10000/aa515779-dad9-4994-b7d2-d672a7c8938a.root (2500 events), the skimmed file size for DT clusters was 6.2MB, the skimmed file size for delayed jets was 4.9MB, and the size of the unskimmed AOD file in each case was 551MB.

PR validation:

Ran with CMSSW_12_4_0_pre1 and used the config files "test_DTCluster_cfg.py" and "test_DelayedJet_cfg.py", which are both included in the PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37509/29222

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2022

A new Pull Request was created by @rtschmitz for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @wajidalikhan, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@kskovpen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc595a/23886/summary.html
COMMIT: 8b5e393
CMSSW: CMSSW_12_4_X_2022-04-13-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37509/23886/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3592997
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 16, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants