Change tracks to optional requirement in HLTDisplacedEgammaFilter #37565
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37565/29296
|
|
A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -40,7 +40,9 @@ HLTDisplacedEgammaFilter::HLTDisplacedEgammaFilter(const edm::ParameterSet& iCon | |||
| inputToken_ = consumes<trigger::TriggerFilterObjectWithRefs>(inputTag_); | |||
| rechitsEBToken_ = consumes<EcalRecHitCollection>(rechitsEB); | |||
| rechitsEEToken_ = consumes<EcalRecHitCollection>(rechitsEE); | |||
| inputTrkToken_ = consumes<reco::TrackCollection>(inputTrk); | |||
| if (!inputTrk.label().empty()) { | |||
There was a problem hiding this comment.
I suggest to add a bool config parameter named useTrackVeto, set to true by default via fillDescriptions, rather than giving implicit meaning to certain input-tags (in this case the empty one).
There was a problem hiding this comment.
Will do. I will make a fresh commit.
arsahasransu
force-pushed
the
ForTSGv2Menu
branch
from
15f4124
to
0d4b7d1
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37565/29303
|
|
Pull request #37565 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
arsahasransu
force-pushed
the
ForTSGv2Menu
branch
from
0d4b7d1
to
d8ad893
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37565/29320
|
|
Pull request #37565 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ffc98/23927/summary.html Comparison SummarySummary:
|
|
+hlt |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
+1 |
PR description:
The track requirement in the HLTDisplacedEgamma filter is made optional. I want to make use of this filter to set cuts on the smin, smaj and time variables. These can be done based on ECal rechit info only and no track requirement. Implementation ignores track-based restriction, when the input tag for the track collection is empty.
PR validation:
The config was privately tested and verified to work properly.