Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing Buildfile dependencies on hepmc #37568

Merged
merged 1 commit into from Apr 18, 2022

Conversation

davidlange6
Copy link
Contributor

Ensure that any package using hepmc in its interface or src declares that dependency in its build file.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37568/29305

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

  • FastSimulation/SimplifiedGeometryPropagator (fastsim)
  • Fireworks/Core (visualization)
  • GeneratorInterface/AMPTInterface (generators)
  • GeneratorInterface/BeamHaloGenerator (generators)
  • GeneratorInterface/Core (generators)
  • GeneratorInterface/CosmicMuonGenerator (generators)
  • GeneratorInterface/ExhumeInterface (generators)
  • GeneratorInterface/Herwig6Interface (generators)
  • GeneratorInterface/HijingInterface (generators)
  • GeneratorInterface/Hydjet2Interface (generators)
  • GeneratorInterface/HydjetInterface (generators)
  • GeneratorInterface/PartonShowerVeto (generators)
  • GeneratorInterface/PomwigInterface (generators)
  • GeneratorInterface/PyquenInterface (generators)
  • GeneratorInterface/Pythia6Interface (generators)
  • GeneratorInterface/ReggeGribovPartonMCInterface (generators)
  • HLTriggerOffline/Egamma (dqm)
  • IOMC/EventVertexGenerators (simulation)

@SiewYan, @ssekmen, @Dr15Jones, @mkirsano, @lveldere, @alja, @makortel, @emanueleusai, @civanch, @mdhildreth, @cmsbuild, @GurpreetSinghChahal, @jfernan2, @ahmad3213, @sbein, @alberto-sanchez, @Saptaparna, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mkirsano, @alja, @cbaus, @missirol, @grzanka, @alberto-sanchez, @matt-komm, @mtosi, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Apr 14, 2022

please test

@alja
Copy link
Contributor

alja commented Apr 14, 2022

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6d6a29/23914/summary.html
COMMIT: f31d56b
CMSSW: CMSSW_12_4_X_2022-04-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37568/23914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3593009
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 14, 2022

+1

@jfernan2
Copy link
Contributor

+1

@qliphy
Copy link
Contributor

qliphy commented Apr 18, 2022

@cms-sw/generators-l2 Any comments?

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 380f544 into cms-sw:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants