Made debug static const in HelixArbitraryPlaneCrossing

[Dr15Jones]

To avoid complaints by the static analyzer, changed a static only
used for debugging to be const and made the version used only
with a conditional statement be thread safe.

[Dr15Jones]

NOTE: The actual code change is behind a #ifdef which is not set. I did test with the condition true and the code compiles.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made debug static const in HelixArbitraryPlaneCrossing

It involves the following packages:

TrackingTools/GeomPropagators

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @cerati, @GiacomoSguazzoni, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3757/1395/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3757/1395/summary.html

[Dr15Jones]

@slava77 @anton-a ping?

[slava77]

+1

for #3757 4d3e27f
tested in CMSSW_7_1_X_2014-05-12-0200 (test area sign369decB)
no changes observed in monitored quantities

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?