Run2-gex128 Rearrange 2017 scenarios in view of updates foreseen

[bsunanda]

PR description:

Rearrange 2017 scenarios in view of updates foreseen

PR validation:

Use the runTheMatrix test workflows as well as cfg'sin test area

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37593/29353

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37593/29354

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #37593 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b75dd/23966/summary.html
COMMIT: 2d6ea8c
CMSSW: CMSSW_12_4_X_2022-04-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37593/23966/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593159
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593135
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cvuosalo]

You're changing Extended2017 to Extended2017Plan0. Is "Extended2017" not currently used in any code?

[bsunanda]

I plan to use the new 2017 scenario there. I consulted with HCAL DPG SW expert about this. The current status is confusing. The defaukt usage is with 2017Plan1. The new 2017 scenario also uses this but with something which can work with dd4hep. As soon as this IB is integrated I shall migrate the versions in HcalCommonData to CMSCommonData. This will be for 2017 as well as 2018.

[bsunanda]

All current 2017 applications use the DB version.

[cvuosalo]

+1

[bsunanda]

@srimanob Please sign this PR

[srimanob]

Do we need this urgently? My proposal is to discuss first in the SIM meeting?
What is the definition of Plan0?

[civanch]

@bsunanda , all, would it be more safe not to rename whatever file but create a new one with clear name like "DD4hep" inside? The alternative may be to edit existing file, this from one hand may be risky but reduce necessity to edit downstream files - we may come to situation of expansion of modifications.

A safe variant may be to preserve old files with different name and edit existing.

[bsunanda]

@srimanob Please sign it now

[bsunanda]

In a subsequent PR I shall introduce what we discussed in the SIM meeting.

[srimanob]

+Upgrade

There will be a follow up PR as discussed in the SIM meeting, https://indico.cern.ch/event/1153217/, on migration Run-2 to DD4hep.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

@bsunanda After this PR gets merged, there are some unit test failures appearing in the IB test, please have a look and fix:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_4_X_2022-04-25-1100/unitTestLogs/CalibTracker/SiStripESProducers#/

----- Begin Fatal Exception 25-Apr-2022 15:12:57 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
[0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_4_X_2022-04-25-1100/src/CalibTracker/SiStripESProducers/test/python/SiStripBadAPVListBuilder_byHand_cfg.py
Exception Message:
unknown python problem occurred.
ModuleNotFoundError: No module named 'Configuration.Geometry.GeometryExtended2017_cff'

[qliphy]

https://github.com/cms-sw/cmssw/blob/CMSSW_12_3_X/CalibTracker/SiStripESProducers/test/python/SiStripBadAPVListBuilder_byHand_cfg.py#L117
https://github.com/cms-sw/cmssw/blob/master/CondTools/SiStrip/test/SiStripApvGainFromASCIIFile_cfg.py#L28
https://github.com/cms-sw/cmssw/blob/master/CondTools/SiPixel/test/SiPixelTemplateDBObjectUploader_cfg.py#L177

[bsunanda]

@qliphy @perrotta the PR #37674 will cure this.