Adding pre-selection to input (AK4) jets for tau RECO

[jpavel]

This PR is replacement of #3594 by including changes on top of #3631
It adds the possibility to reject some jets as an input seeds for tau reconstruction based on their pt and eta. It is turned on by default and the requirements for running the tau RECO sequence are

1. pt > 14 GeV
2. |eta| < 2.5

The performance change is expected - loss of efficiency for very low pt true taus, and also decreased fake rate for very low pt jets.

However, no change is expected for the taus passing recommended kinematical cuts (pt > 20 GeV + |eta| < 2.3).

This is shown on slides: https://indico.cern.ch/event/316898/material/0/0.pdf

Additionally, one can expect improvement of overall timing needed for tauRECO (as the algorithm is executed fewer times) and also size reduction in the RECO PFTauCollection, as it will contain fewer candidates.

PR's #3558 and #3594 are being closed as they have been rendered moot by the #3631

@veelken and @monicava, this is something you wanted to watch as well

[cmsbuild]

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_1_X.

Adding pre-selection to input (AK4) jets for tau RECO

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestTqafTopTools had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1399/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1399/summary.html

[cmsbuild]

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestTqafTopHitFit had ERRORS
---> test runtestTqafTopTools had ERRORS
---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopKinFitter had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafTopJetCombination had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestTqafExamples had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1403/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1403/summary.html

[jpavel]

Hi, it seems to me that the test failures are not the fault of this PR:
The errors like

----- Begin Fatal Exception 09-May-2014 14:53:25 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'outpath'
   [2] Calling event method for module PoolOutputModule/'out'
   [3] Calling produce method for unscheduled module PATJetSelector/'selectedPatJets'
   [4] Calling produce method for unscheduled module PATJetProducer/'patJets'
   [5] Calling produce method for unscheduled module JetChargeProducer/'patJetCharge'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::AssociationVector<edm::RefToBaseProd<reco::Jet>,std::vector<edm::RefVector<std::vector<reco::Track>,reco::Track,edm::refhelper::FindUsingAdvance<std::vector<reco::Track>,reco::Track> > >,edm::RefToBase<reco::Jet>,unsigned int,edm::helper::AssociationIdenticalKeyReference>
Looking for module label: ak4JetTracksAssociatorAtVertexPF
Looking for productInstanceName: 

or

----- Begin Fatal Exception 09-May-2014 14:54:10 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 9 event: 801
   [1] Running path 'p'
   [2] Calling event method for module PFJetFwdPtrProducer/'ak4PFJetsPtrs'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::PFJet
Looking for module label: ak4PFJets
Looking for productInstanceName: 

seem to be caused by lack of product in the input file. Perhaps some IO rules should be added to read ak5* collection in case the ak4 is not available.

[slava77]

I'm guessing #3793 will help.
It was merged in time for 05-10-1400.
@cmsbuild, please rerun the tests once this release is out

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1446/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3762/1446/summary.html

[slava77]

+1

for #3762 836b36b

tested in CMSSW_7_1_X_2014-05-13-1400 (test area sign372)

changes in tau variables are pretty massive (most visible from pt cuts, as expected). At a quick glance, the changes are as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?