Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] simple RECO squence for SPLASH runs #37623

Merged
merged 4 commits into from Apr 23, 2022

Conversation

pmandrik
Copy link
Contributor

@pmandrik pmandrik commented Apr 19, 2022

PR description:

For the beam SPLASH runs simplification of RECO sequence is proposed in order to speed up event processing in Event Display DQM clients. As simplified sequence is needed only for SPLASH runs, not for regular 'cosmic' and 'beam operation', the customization in visualizationProcessing function is applied when beamSplashRun option is True.

PR validation:

Tested locally, to be tested at P5 in production using on-going runs.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #37624
for ongoing operation at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2022

A new Pull Request was created by @pmandrik for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • DQM/Integration (dqm)

@perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @Martin-Grunewald, @missirol, @threus, @fabiocos, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Pull request #37623 was updated. @perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @davidlange6 can you please check and sign again.

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71b732/24038/summary.html
COMMIT: e46fd00
CMSSW: CMSSW_12_3_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37623/24038/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3697105
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit edd2392 into cms-sw:CMSSW_12_3_X Apr 23, 2022
@perrotta
Copy link
Contributor

Uhm, I did not realize that this PR was not in the master.
@pmandrik could you please make a master version of it now: it will be merged in the reverse order, but ok this seems safe enough not to require to revert this 12_3_X PR (provided that its master version is made available as soon as possible)

@perrotta
Copy link
Contributor

backport of #37624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants