Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc 490 warnings. #3763

Merged
merged 1 commit into from May 8, 2014
Merged

Fix gcc 490 warnings. #3763

merged 1 commit into from May 8, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented May 8, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix gcc 490 warnings.

It involves the following packages:

CondFormats/JetMETObjects

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @ggovi, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix gcc 490 warnings.

It involves the following packages:

CondFormats/JetMETObjects

@apfeiffer1, @nclopezo, @monttj, @cmsbuild, @ggovi, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor Author

ktf commented May 8, 2014

The last reworking was not sufficient to get the errors go away. This is. Bypassing signatures, complain if not ok.

ktf added a commit that referenced this pull request May 8, 2014
Gcc 4.9.0 -- Fix gcc 490 warnings.
@ktf ktf merged commit d8afcae into cms-sw:CMSSW_7_1_X May 8, 2014
@ktf ktf deleted the fix-warnings branch May 8, 2014 20:43
@vadler
Copy link

vadler commented May 8, 2014

+1
Sorry, I used gcc481 earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants