PPS Geant4 sensitive detectors

[civanch]

PR description:

Evaluating #37409 number of problems were identified in Geant4 sensitive detector (SD) classes of PPS. In this PR all 3 PPS SDs are updated:

1. No more run time checks on physics volumes names, because geometry is fixed and depth in geometry structures is also fixed (all other sub-detectors do not use names in run time).
2. Corrected signatures of methods: which are public/private/protected according to the base class.
3. Removed unused methods and variables.
4. Renamed variables to follow code guidelines.
5. Make all 3 SD classes uniform.
6. Check energy deposition at a step and any run time processing is performed only if it is above zero.
7. Improved debug printouts.
8. Removed obsolete classes.

No change is expected in testing.

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport that PR:

no backport is expected

[civanch]

@fabferro , in general this PR is technical and should not change physics but independent checks may be useful.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37648/29445

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimG4CMS/PPS/src/PPSDiamondOrganization.cc modified in PR(s): Fix deprecation warnings in SimG4CMS #37409
  • File SimG4CMS/PPS/src/PPSPixelOrganization.cc modified in PR(s): Fix deprecation warnings in SimG4CMS #37409
  • File SimG4CMS/PPS/src/PPSStripOrganization.cc modified in PR(s): Fix deprecation warnings in SimG4CMS #37409

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4CMS/PPS (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @fabiocos, @slomeo, @bsunanda this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd2c9a/24107/summary.html
COMMIT: 32519b6
CMSSW: CMSSW_12_4_X_2022-04-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37648/24107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fd2c9a/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

please test for CMSSW_12_4_GEANT4_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd2c9a/24124/summary.html
COMMIT: 32519b6
CMSSW: CMSSW_12_4_GEANT4_X_2022-04-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37648/24124/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 63994 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3589937
• DQMHistoTests: Total failures: 431233
• DQMHistoTests: Total nulls: 298
• DQMHistoTests: Total successes: 3158384
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6870000000000003 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.596 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 4.896 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.715 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -0.367 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: found differences in 14 / 47 workflows

[civanch]

The lost of regression for GEANT4 branch comparison likely connected with not correct comparisons. Locally, this PR does not change list of hits.

[perrotta]

@fabferro , in general this PR is technical and should not change physics but independent checks may be useful.

I think this PR can be merged. But please @fabferro or someone else from @cms-sw/ctpps-dpg-l2 have a look and let us know

[diemort]

@civanch @perrotta @fabferro I'll perform local tests in the following days and let you.

[diemort]

@civanch @perrotta @fabferro FYI, I got small differences after these changes, but want to double-check before a final answer. Hope to finish it by tomorrow.

[qliphy]

@diemort Any news? Thanks!

[diemort]

@qliphy I'm getting some unexpected differences in 12_4. Let me further check to be sure. Feedback ASAP.

[qliphy]

@diemort thanks! any follow up?

[diemort]

@civanch @perrotta @qliphy I'm sorry for the late feedback, but I had to deal with some issues in our simulation. I've made a comparison between a base simulation and the changes proposed in this PR: validation plots shown here.

From my side, no issues are found with the proposed changes. If @fabferro agrees, merging may proceed.

[fabferro]

@civanch @perrotta @qliphy I'm sorry for the late feedback, but I had to deal with some issues in our simulation. I've made a comparison between a base simulation and the changes proposed in this PR: validation plots shown here.

From my side, no issues are found with the proposed changes. If @fabferro agrees, merging may proceed.

Then it's ok for me to go on with merging.

[perrotta]

please test

[perrotta]

Thank you @diemort and @fabferro
Let refresh the 12 days old tests , then we'll proceed to merge this PR

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd2c9a/24437/summary.html
COMMIT: 32519b6
CMSSW: CMSSW_12_4_X_2022-05-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37648/24437/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700548
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700524
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Endorsed by PPS contacts