Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[12_3_X] simple RECO squence for SPLASH runs" #37663

Merged
merged 1 commit into from Apr 23, 2022

Conversation

perrotta
Copy link
Contributor

Reverts #37623

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)
  • DQM/Integration (dqm)

@perrotta, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @qliphy, @davidlange6, @micsucmed, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @Martin-Grunewald, @missirol, @threus, @fabiocos, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

Let revert this PR, that was merged in 12_3 by mistake: there are still discussions ongoing in the master version, that should better sorted out before backporting

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit ac4bac6 into CMSSW_12_3_X Apr 23, 2022
@smuzaffar smuzaffar deleted the revert-37623-splash_ed_simple_reco branch April 25, 2022 11:32
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04766f/24242/summary.html
COMMIT: 80c4586
CMSSW: CMSSW_12_3_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37663/24242/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697105
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants