Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run3 era for AlCaPhiSymEcal_Nano #37668

Merged
merged 1 commit into from Apr 25, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 25, 2022

PR description:

Title says it all, this was essentially just forgotten in #37627 (sorry!)

PR validation:

scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Already included in the backport commit 2371683

@tvami
Copy link
Contributor Author

tvami commented Apr 25, 2022

assign alca

@tvami
Copy link
Contributor Author

tvami commented Apr 25, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37668/29486

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @qliphy, @davidlange6, @fabiocos, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1bc58c/24193/summary.html
COMMIT: d8d9f28
CMSSW: CMSSW_12_4_X_2022-04-25-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37668/24193/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1bc58c/39434.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695404
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Apr 25, 2022

+alca

@tvami
Copy link
Contributor Author

tvami commented Apr 25, 2022

@cms-sw/orp-l2 let's merge this so the backport can go into the upcoming 12_3_X release, using which we can test this at a new T0 replay

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 23db5f0 into cms-sw:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants