Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Remove some unnecessary framework includes #37706

Merged
merged 2 commits into from Apr 29, 2022

Conversation

makortel
Copy link
Contributor

PR description:

This PR removes unnecessary #includes of legacy EDModule headers plus some more of framework headers (that were clearly unused). These #includes were identified as part of #37592. The first commit moves one kNull object from global to anonymous namespace that I spotted along the way.

PR validation:

Code compiles.

The constant is an implementation detail, and too generic name for
global namespace.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37706/29534

  • This PR adds an extra 440KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm)
  • DQM/CSCMonitorModule (dqm)
  • DQM/DTMonitorModule (dqm)
  • DQM/GEM (dqm)
  • DQM/HLTEvF (dqm, hlt)
  • DQM/L1TMonitorClient (dqm)
  • DQMOffline/Hcal (dqm)
  • DQMOffline/JetMET (dqm)
  • DQMOffline/L1Trigger (dqm, l1)
  • DQMOffline/Muon (dqm)
  • DQMOffline/PFTau (dqm)
  • DQMOffline/Trigger (dqm)
  • DQMServices/Components (dqm)
  • HLTriggerOffline/Egamma (dqm)
  • HLTriggerOffline/Exotica (dqm)
  • HLTriggerOffline/HeavyFlavor (dqm)
  • HLTriggerOffline/Higgs (dqm)
  • HLTriggerOffline/Muon (dqm)
  • Validation/RecoParticleFlow (dqm)

@Martin-Grunewald, @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @abbiendi, @CeliaFernandez, @bsunanda, @watson-ij, @ahinzmann, @missirol, @cericeci, @mmarionncern, @battibass, @silviodonato, @abdoulline, @jhgoh, @jdolen, @sscruz, @seemasharmafnal, @ptcox, @trocino, @schoef, @rociovilar, @barvic, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @hatakeyamak, @mtosi, @HuguesBrun, @Fedespring, @calderona, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1b79/24263/summary.html
COMMIT: d346cf0
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37706/24263/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1001.2 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695434
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695410
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@missirol
Copy link
Contributor

+hlt

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants