New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM] Remove some unnecessary framework includes #37706
Conversation
The constant is an implementation detail, and too generic name for global namespace.
45f7afb
to
d346cf0
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37706/29534
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@Martin-Grunewald, @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e1b79/24263/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+l1 |
+hlt |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes unnecessary
#include
s of legacy EDModule headers plus some more of framework headers (that were clearly unused). These#include
s were identified as part of #37592. The first commit moves onekNull
object from global to anonymous namespace that I spotted along the way.PR validation:
Code compiles.