MTD validation: add histograms for particle identification monitoring

[fabiocos]

PR description:

This PR proposes and extension of the MTD validation code, primarily in the Primary4DVertexValidation class, adding a set of plots to study the particle identification performances based on the 4D vertex reconstruction. This code has been used as an input to AN-22-060.

The memory impact of this addition is of the order of 10 kB, as provided by dqmMemoryStats.py:

158d157
< 38.23 KiB        MTD/Vertices
166a166
> 28.86 KiB        MTD/Vertices
361c361
< Total bytes: 412461.59 KiB
---
> Total bytes: 412452.22 KiB

PR validation:

Phase 2 test workflows compile and run, providing the desired output. Private samples of O(50k) events with PU have been produced with these updates.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37842/29767

• This PR adds an extra 136KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b53ea7/24498/summary.html
COMMIT: 4c1cd62
CMSSW: CMSSW_12_4_X_2022-05-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37842/24498/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3700704
• DQMHistoTests: Total failures: 301
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3700381
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 74.93600000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 9.367 KiB MTD/Vertices
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[fabiocos]

@qliphy @perrotta not sure whether the error above is in any way related to this PR

[perrotta]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b53ea7/24529/summary.html
COMMIT: 4c1cd62
CMSSW: CMSSW_12_4_X_2022-05-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37842/24529/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3701451
• DQMHistoTests: Total failures: 306
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3701122
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 74.93200000000002 KiB( 48 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 9.367 KiB MTD/Vertices
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 206 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1