Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gathering detail plots into directories, online & offline & relval & … #37852

Merged
merged 1 commit into from May 10, 2022

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented May 7, 2022

PR description:

We have several updates on GEM onlineDQM.

  • Plots for detailed information per chambers are gathered into directories
  • Online & offline & relval & allplot modes
  • Removed non-useful plots and stuffs

This PR is a backport to CMSSW_12_3_X of #37786.

PR validation:

Test are done and one can check again by runTheMatrix workflows

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

A new Pull Request was created by @quark2 for CMSSW_12_3_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • Validation/Configuration (dqm, simulation)

@civanch, @emanueleusai, @mdhildreth, @cmsbuild, @jfernan2, @ahmad3213, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @rovere, @watson-ij, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52cd50/24520/summary.html
COMMIT: abc9ef2
CMSSW: CMSSW_12_3_X_2022-05-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37852/24520/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 126462 lines to the logs
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3693328
  • DQMHistoTests: Total failures: 28
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3693278
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 65153.668 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 147.714 KiB GEM/Digis
  • DQMHistoSizes: changed ( 10024.0,... ): -18.914 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11634.0,... ): 2170.807 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): 11.172 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 11634.0,... ): 0.770 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 23234.0,... ): 4332.684 KiB GEM/Digis
  • DQMHistoSizes: changed ( 23234.0,... ): -5.781 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 35034.0,... ): 6048.131 KiB GEM/Digis
  • DQMHistoSizes: changed ( 35034.0,... ): -13.969 KiB GEM/RecHits
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 8, 2022

+1

@emanueleusai
Copy link
Member

testing at P5

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #37786

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb7e18c into cms-sw:CMSSW_12_3_X May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants