Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] introduce GEMChMap for GE21 chambers [12_3_X] #37855

Merged
merged 1 commit into from May 9, 2022

Conversation

yeckang
Copy link
Contributor

@yeckang yeckang commented May 8, 2022

PR description:

  • The current GEM electronics mapping can not handle the vfat that reads the signal from more than 1 unit detector module.
  • In the GE21, a single vfat reads the signal from 2 different unit detector modules.
  • The new electronics mapping format will be introduced with this PR.
  • No changes are expected with this PR.

PR validation:

  • The code format has applied with scram build code-format and scram build code-checks.
  • The branch is compileable.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2022

A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_12_3_X.

It involves the following packages:

  • CondCore/GEMPlugins (db)
  • CondFormats/DataRecord (db, alca)
  • CondFormats/GEMObjects (db)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@jshlee, @mmusich, @seemasharmafnal, @watson-ij, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented May 8, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented May 8, 2022

backport of #37777

@tvami
Copy link
Contributor

tvami commented May 8, 2022

type gem

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a766e/24523/summary.html
COMMIT: e20042b
CMSSW: CMSSW_12_3_X_2022-05-08-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37855/24523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696087
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696063
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 9, 2022

+1

@cmsbuild cmsbuild merged commit 5e29664 into cms-sw:CMSSW_12_3_X May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants