New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable forceGeneration for L1 O2O online producers #37861
Enable forceGeneration for L1 O2O online producers #37861
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37861/29809
|
A new Pull Request was created by @panoskatsoulis (Panos) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
assign db
|
New categories assigned: db @ggovi,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66ce46/24542/summary.html Comparison SummarySummary:
|
@panoskatsoulis I believe this should be backported to 12_3_X |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
backported here #37886 |
@panoskatsoulis would it be possible to update it, as you are also proposing, so that the unit tests can actually be used to catch these kind of issues? |
+1
|
Hi @perrotta, |
sorry for delaying it that much |
PR description:
This PR is complementary to #37602 for fixing several issues of the L1o2o in 12_3 onward.
One of the main problems was that since the producers for the requested ES Rcds are now run in construction time, several exceptions that where handled in the
produce()
method of the L1L1CondDBPayloadWriterExt
module now are impossible to be handled properly.After the P5 deployment of the changes included in 37602, one last case has been found where an exception was thrown when the key of a single subsystem was already included in the db and in this case the o2o procedure was stopped for this subsystem (with an exception to be handled by the code block in
produce()
).https://github.com/panoskatsoulis/cmssw/blob/0e675061b02ec7636f1a7f726647b7f6dcac2834/CondTools/L1Trigger/interface/L1ConfigOnlineProdBase.h#L123-L157
This PR includes cfg modifications needed for forcing the L1 online producers to run no matter if the resulting object exist in the db (however will not be uploaded if it already exist)
It's required for cases where the following happens
PR validation:
This modification is tested in Prep and also is used atm as local custom patch for the L1 O2O Jobs at P5 (without problems)
The unit tests implemented in 37602 didn't catch this problem because the local sqlite file from the data repo was not prepared for this "real-case" scenario that occurred when we tested with more keys.
So, the file in https://github.com/cms-data/L1TriggerConfig-L1TConfigProducers is meant to be updated too for better future testing.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not sure if a backport is needed
Atm these mods are implemented in a custom patch on the
conddb-1
machine.In case more 12_3 releases are going to be deployed for the o2o machines at P5 a backport is also required.