Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable forceGeneration for L1 O2O online producers #37861

Merged
merged 1 commit into from May 10, 2022

Conversation

panoskatsoulis
Copy link
Contributor

PR description:

This PR is complementary to #37602 for fixing several issues of the L1o2o in 12_3 onward.
One of the main problems was that since the producers for the requested ES Rcds are now run in construction time, several exceptions that where handled in the produce() method of the L1 L1CondDBPayloadWriterExt module now are impossible to be handled properly.

After the P5 deployment of the changes included in 37602, one last case has been found where an exception was thrown when the key of a single subsystem was already included in the db and in this case the o2o procedure was stopped for this subsystem (with an exception to be handled by the code block in produce()).
https://github.com/panoskatsoulis/cmssw/blob/0e675061b02ec7636f1a7f726647b7f6dcac2834/CondTools/L1Trigger/interface/L1ConfigOnlineProdBase.h#L123-L157

This PR includes cfg modifications needed for forcing the L1 online producers to run no matter if the resulting object exist in the db (however will not be uploaded if it already exist)
It's required for cases where the following happens

  • L1system 1 exists
  • L1system 2 exists
  • L1system 3 new key

PR validation:

This modification is tested in Prep and also is used atm as local custom patch for the L1 O2O Jobs at P5 (without problems)
The unit tests implemented in 37602 didn't catch this problem because the local sqlite file from the data repo was not prepared for this "real-case" scenario that occurred when we tested with more keys.
So, the file in https://github.com/cms-data/L1TriggerConfig-L1TConfigProducers is meant to be updated too for better future testing.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not sure if a backport is needed
Atm these mods are implemented in a custom patch on the conddb-1 machine.
In case more 12_3 releases are going to be deployed for the o2o machines at P5 a backport is also required.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37861/29809

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

A new Pull Request was created by @panoskatsoulis (Panos) for master.

It involves the following packages:

  • L1TriggerConfig/L1TConfigProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor

Please test

@francescobrivio
Copy link
Contributor

francescobrivio commented May 9, 2022

assign db

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

New categories assigned: db

@ggovi,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66ce46/24542/summary.html
COMMIT: 0e67506
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37861/24542/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696633
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3696597
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 9, 2022

@tvami
Copy link
Contributor

tvami commented May 9, 2022

@panoskatsoulis I believe this should be backported to 12_3_X

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@panoskatsoulis
Copy link
Contributor Author

backported here #37886

@perrotta
Copy link
Contributor

So, the file in https://github.com/cms-data/L1TriggerConfig-L1TConfigProducers is meant to be updated too for better future testing.

@panoskatsoulis would it be possible to update it, as you are also proposing, so that the unit tests can actually be used to catch these kind of issues?

@perrotta
Copy link
Contributor

+1

  • Maybe the data file with the updated scenarios to be tested could be made available before we merge also the backport PR...

@cmsbuild cmsbuild merged commit 1f74939 into cms-sw:master May 10, 2022
@panoskatsoulis
Copy link
Contributor Author

panoskatsoulis commented May 10, 2022

+1

* Maybe the data file with the updated scenarios to be tested could be made available before we merge also the backport PR...

Hi @perrotta,
yes ok, I will also follow up with the updated sqlite file by tomorrow
(it needs some local testing)

@panoskatsoulis
Copy link
Contributor Author

+1

* Maybe the data file with the updated scenarios to be tested could be made available before we merge also the backport PR...

sorry for delaying it that much
cms-data/L1TriggerConfig-L1TConfigProducers#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants