Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EGM HLT tags to data GTs and introduce fixed snapshot in online GTs #37870

Merged
merged 2 commits into from May 10, 2022

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented May 9, 2022

PR description:

This PR is a follow-up of PR #37557. As agreed here, the EGM supercluster regression for HLT was included also in the Run3 offline GTs (auto:run3_data and auto:run3_data_relval) and to the Prompt GT.

The tags included in the GTs are:

Label: pfscecal_EBCorrection_online, Tag: pfscecal_EBCorrection_hlt_v1
Label: pfscecal_EBUncertainty_online, Tag: pfscecal_EBUncertainty_hlt_v1
Label: pfscecal_EECorrection_online, Tag: pfscecal_EECorrection_hlt_v1
Label: pfscecal_EEUncertainty_online, Tag: pfscecal_EEUncertainty_hlt_v1

We also take the chance to do a forward port of PR #37670 on what concerns the revival of an AlCaDB policy of not having any GT with an infinite snapshot in autoCond.py. The new GTs with fixed snapshot are: 123X_dataRun3_HLT_frozen_v2, 123X_dataRun3_Express_frozen_v1 and 123X_dataRun3_Prompt_frozen_v1.

The difference in GTs are shown below. We expect to see as differences only the EGM tags listed above for the offline and Prompt GTs and no differences for the HLT and Express frozen GTs.

run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v2/123X_dataRun3_HLT_v7

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Express_frozen_v1/123X_dataRun3_Express_v5

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_frozen_v1/123X_dataRun3_Prompt_v7

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v5/123X_dataRun3_v4

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v4/123X_dataRun3_relval_v3

FYI @Martin-Grunewald , @missirol , @cms-sw/egamma-pog-l2

PR validation:

nohup runTheMatrix.py -l 138.4,138.3,136.897 --ibeos -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

forward port of PR #37670
there will be a backport to 123X.

@malbouis
Copy link
Contributor Author

malbouis commented May 9, 2022

test parameters:

  • 138.3,136.897

@missirol
Copy link
Contributor

missirol commented May 9, 2022

@malbouis , thanks for this follow-up.

One question: would it make sense to also update run3_hlt_relval, so that it matches what is in 123X_dataRun3_HLT_frozen_v1 (except for the L1T menu)?

IIuc, with this PR we would have 123X_dataRun3_HLT_frozen_v1 (run3_hlt) and 123X_dataRun3_HLT_relval_v4 (run3_hlt_relval), and those have IOV differences:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_frozen_v1/123X_dataRun3_HLT_relval_v4

It seems like it would make things clearer (I don't think it would make much of a difference in the actual tests).

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37870/29818

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

A new Pull Request was created by @malbouis for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented May 9, 2022

@malbouis , thanks for this follow-up.

One question: would it make sense to also update run3_hlt_relval, so that it matches what is in 123X_dataRun3_HLT_frozen_v1 (except for the L1T menu)?

IIuc, with this PR we would have 123X_dataRun3_HLT_frozen_v1 (run3_hlt) and 123X_dataRun3_HLT_relval_v4 (run3_hlt_relval), and those have IOV differences: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_frozen_v1/123X_dataRun3_HLT_relval_v4

It seems like it would make things clearer (I don't think it would make much of a difference in the actual tests).

@missirol , good point! I have created a new GT 123X_dataRun3_HLT_relval_v5 and 123X_dataRun3_HLT_frozen_v2 so that the IOV differences are kept to a minimal: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v2/123X_dataRun3_HLT_relval_v5

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37870/29836

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

Pull request #37870 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@malbouis
Copy link
Contributor Author

malbouis commented May 9, 2022

test parameters:

  • workflows=138.3,136.897

@malbouis
Copy link
Contributor Author

malbouis commented May 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5696d/24546/summary.html
COMMIT: ded130e
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37870/24546/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d5696d/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d5696d/138.3_Splashes+RunMinimumBias2021Splash+COPYPASTER3+RECODR3Splash+HARVESTDR3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3800116
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3800092
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 214 log files, 48 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • PR in line with description
  • tests are clean
  • @malbouis please fix the Prompt GT diff link in the PR description (it has 123X_dataRun3_Prompt_frozen_v2 instead of 123X_dataRun3_Prompt_frozen_v1)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants