Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks-master: Fix position of phase2 clusters in 3D and projected views #37873

Merged
merged 2 commits into from May 11, 2022

Conversation

alja
Copy link
Contributor

@alja alja commented May 9, 2022

Description

This PR fixes positioning of Phase -2 clusters in the Fireworks event display.
In the screenshot below clusters are rendered as blue point and a marker.

strip-len

@alja
Copy link
Contributor Author

alja commented May 9, 2022

+1

@alja
Copy link
Contributor Author

alja commented May 9, 2022

@slava77 This is the correction for phase2 clusters. Let me know if you want to backport this change.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37873/29844

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

A new Pull Request was created by @alja (Alja Mrak Tadel) for master.

It involves the following packages:

  • Fireworks/Tracks (visualization)

can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e4e9d/24551/summary.html
COMMIT: 8dc934a
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37873/24551/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e4e9d/24551/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e4e9d/24551/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2974 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696633
  • DQMHistoTests: Total failures: 6324
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3690287
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@qliphy
Copy link
Contributor

qliphy commented May 10, 2022

@alja Would you please add some more meaningful detailed description?

@alja alja changed the title Fireworks-master: Fix position of phase2 clusters Fireworks-master: Fix position of phase2 clusters in 3D and projected views May 10, 2022
@alja
Copy link
Contributor Author

alja commented May 10, 2022

@qliphy I edited title and the comment so it is more clear the PR is about event display.

@qliphy
Copy link
Contributor

qliphy commented May 11, 2022

+1

@cmsbuild cmsbuild merged commit 44f2814 into cms-sw:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants