New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill LumiRange for BeamSpotOnline objects #37875
Conversation
type bug-fix |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37875/29854
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbd83a/24556/summary.html Comparison SummarySummary:
|
+1 |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As noticed in #37858 (comment) the
lumiRange
member of the BeamSpotOnline objects was never filled inDQM/BeamMonitor
and it defaulted to an empty string.This PR correctly fills the value with the string
[firstLS] - [lastLS]
used in the BeamSpot fit.PR validation:
Code compiles plus tested privately (with a
cout
) that the lumiRange parameter is correctly formatted.Backport:
Not a backport, but a backport to 12_3_X will be provided shortly.
FYI @dzuolo @gennai