New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copies RawEventContent compression settings for Repack jobs #38049
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38049/30131
|
A new Pull Request was created by @germanfgv (Germán Felipe Giraldo Villa) for master. It involves the following packages:
@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@qliphy can we trigger test for this please? |
please test |
allow @germanfgv test rights |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-009258/24966/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Drops RAWEventContent configuration from repack output, while keeping it compression configuration. Fix to #37791.
Following the discussion in #38025 (comment), this PR uses
copy
to avoid propagating changes done in Repack.py back to the RawEventContent objectPR validation:
Used RunRepack.py to generate a test configuration. The resulting PSet had the required output module attributes and the repack job was executed correctly using cmsRun. The produced RAW file included the expected products.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a forwardport of #38025 with improvements after #38025 (comment).