Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[124X] Add EGM regression to online GTs and update Run-3 cosmics MC GTs #38070

Merged
merged 1 commit into from May 25, 2022

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented May 24, 2022

PR description:

backport of #38069

In this PR we intend to:

Note: there will be a follow-up udpate to include the EGM regression also in the offline data GT.

Differences between previous and new GTs are shown below.

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Express_frozen_v2/123X_dataRun3_Express_frozen_v1

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_frozen_v2/123X_dataRun3_Prompt_frozen_v1

phase1_2021_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021cosmics_realistic_deco_v2/124X_mcRun3_2021cosmics_realistic_deco_v1

phase1_2021_cosmics_design
https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/124X_mcRun3_2021cosmics_design_deco_v1

PR validation:

runTheMatrix.py -l 7.23,138.5,138.4 --ibeos -j16

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38069

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2022

A new Pull Request was created by @malbouis for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

test parameters:

  • workflows=7.23

@tvami
Copy link
Contributor

tvami commented May 24, 2022

backport of #38069

@tvami
Copy link
Contributor

tvami commented May 24, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented May 24, 2022

type egamma

@tvami
Copy link
Contributor

tvami commented May 24, 2022

type trk

@cmsbuild cmsbuild added the trk label May 24, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a93a5c/24960/summary.html
COMMIT: 0a1dec3
CMSSW: CMSSW_12_4_X_2022-05-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38070/24960/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a93a5c/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3706183
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3706153
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 213 log files, 45 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 24, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented May 25, 2022

@cms-sw/orp-l2 the IBs seem to be running fine with this change, please merge this at your earliest convenience (we'll have another backport update soon)

@qliphy
Copy link
Contributor

qliphy commented May 25, 2022

+1

@cmsbuild cmsbuild merged commit f92b0ff into cms-sw:CMSSW_12_4_X May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants