Implemented new strategy to generate OI seeds for displaced muons #38076
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38076/30164
|
|
A new Pull Request was created by @alexsr-98 for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
type muon |
|
assign hlt |
|
New categories assigned: hlt @missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df21e5/24988/summary.html Comparison SummarySummary:
|
| if (displacedReco_ && outerTkStateOutside.isValid()) { | ||
| layerCount = 0; | ||
| for (auto it = tob.rbegin(); it != tob.rend(); ++it) { | ||
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TOB layer " << layerCount << std::endl; |
There was a problem hiding this comment.
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TOB layer " << layerCount << std::endl; | |
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TOB layer " << layerCount; |
| out); | ||
| } | ||
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2:::produce: NumSeedsMade = " << numSeedsMade | ||
| << " , layerCount = " << layerCount << std::endl; |
There was a problem hiding this comment.
| << " , layerCount = " << layerCount << std::endl; | |
| << " , layerCount = " << layerCount; |
| << " , layerCount = " << layerCount << std::endl; | ||
| } | ||
|
|
||
| if (L2muonEta < 0.0) { |
There was a problem hiding this comment.
| if (L2muonEta < 0.0) { | |
| else if (L2muonEta < 0.0) { |
What should happen in the case L2muonEta==0?
There was a problem hiding this comment.
It can enter the first, but I think It doesn't really matter.
| out); | ||
| } | ||
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2:::produce: NumSeedsMade = " << numSeedsMade | ||
| << " , layerCount = " << layerCount << std::endl; |
There was a problem hiding this comment.
| << " , layerCount = " << layerCount << std::endl; | |
| << " , layerCount = " << layerCount; |
| if (L2muonEta < 0.0) { | ||
| layerCount = 0; | ||
| for (auto it = tecNegative.rbegin(); it != tecNegative.rend(); ++it) { | ||
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TEC- layer " << layerCount << std::endl; |
There was a problem hiding this comment.
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TEC- layer " << layerCount << std::endl; | |
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2::produce: looping in TEC- layer " << layerCount; |
| out); | ||
| } | ||
| LogTrace("TSGForOIFromL2") << "TSGForOIFromL2:::produce: NumSeedsMade = " << numSeedsMade | ||
| << " , layerCount = " << layerCount << std::endl; |
There was a problem hiding this comment.
| << " , layerCount = " << layerCount << std::endl; | |
| << " , layerCount = " << layerCount; |
| @@ -425,7 +517,7 @@ void TSGForOIFromL2::makeSeedsFromHits(const GeometricSearchDet& layer, | |||
| hitSeedsMade++; | |||
| if (found == numOfHitsToTry_) | |||
| break; | |||
| if (hitSeedsMade > maxHitSeeds_) | |||
| if (hitSeedsMade > maxHitSeeds_) // | |||
There was a problem hiding this comment.
| if (hitSeedsMade > maxHitSeeds_) // | |
| if (hitSeedsMade > maxHitSeeds_) |
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38076/30192
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38076/30197
|
|
Pull request #38076 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df21e5/25019/summary.html Comparison SummarySummary:
|
|
+hlt @alexsr-98 , does this PR need to be backported to |
|
Hi @missirol, yes we need this, do we have to do something to backport it? |
|
I think the backport of this PR should be uncontroversial, as this PR only introduces a new option disabled by default. @cms-sw/reconstruction-l2 , please consider reviewing this PR soonish, since there is a
Yes. Once this PR is merged, you need to open a backport of (the final version of) this PR to the branch Note: the deadline for the next What is the ETA for the changes to the HLT menu (via JIRA ticket) which would make use of this PR? |
|
@missirol Okay I will open the backport as soon as I can. Regarding the last question, we have open a JIRA ticket for this (https://its.cern.ch/jira/browse/CMSHLT-2326) to try to implement this as soon as possible. |
|
+reconstruction
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR implements a new iteration to generate OI seeds for displaced muons. To activate this iteration a flag is added in order to be able to turn off this part of the code and don't interfere with the current algorithm. These slides contain information regarding the problem that we observed and this solution. In slide 7, the performance is shown (compare yellow and brown histograms) and more information regarding the rates and timing is in the backup.
To briefly summarise the PR we have:
Added parameters:
displacedReco: flag to turn on this seeding.SFHldandSFHd: scale factors to fine tune the displaced seeding.Algorithm:
tsosAtIP).