Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the parameter set of the AlcaPCCIntegrator module #38077

Merged
merged 1 commit into from May 25, 2022

Conversation

radla118
Copy link
Contributor

@radla118 radla118 commented May 25, 2022

PR description:

Fixes cms-AlCaDB/AlCaTools#61. This is a follow-up PR of the #37538. The input parameters of the AlcaPCCIntegrator producer are clarified (see #37538 (comment)), and the member variables are fixed (#37538 (comment)). The changes affect some of the configuration files, but the overall workflow and the output is not modified.

PR validation:

Verified by running runtTheMatrix.py -l 1020.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38077/30166

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @radla118 for master.

It involves the following packages:

  • Calibration/LumiAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented May 25, 2022

test parameters:

  • workflows = 1020.0

@tvami
Copy link
Contributor

tvami commented May 25, 2022

type bugfix

@tvami
Copy link
Contributor

tvami commented May 25, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented May 25, 2022

@radla118 please update the PR description with "Fixes cms-AlCaDB/AlCaTools#61 "
Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fcf5e/25000/summary.html
COMMIT: 0d3cbd7
CMSSW: CMSSW_12_5_X_2022-05-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38077/25000/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9fcf5e/1020.0_AlCaLumiPixels2021+AlCaLumiPixels2021+TIER0EXPLP+ALCAEXPLP+ALCAHARVLP+TIER0PROMPTLP

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3650985
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3650955
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 213 log files, 45 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 25, 2022

+alca

  • tests pass, PR is according to the description

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change AlcaPCCIntegrator params to traced
4 participants