[DQM] Fixed filling for TDCfatal in DT Online DQM

[jfernan2]

PR description:

Fixed a bug which made that Overflows and hit rejections/error were wrongly considered as TDCFatal too

PR validation:

Tested with private Online DQM client and run 351168

Checked that runTheMatrix.py -l limited works too

Backport to follow shortly.

[jfernan2]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38078/30167

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38078/30167/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38078/30167/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38078/30169

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• DQM/DTMonitorModule (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cffcbb/24985/summary.html
COMMIT: 79aaf86
CMSSW: CMSSW_12_5_X_2022-05-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38078/24985/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @quark2 [GEM] add DQM plots for GE21/GE0 and Fix on massive LogWarnings #37995
• @malbouis Add EGM regression to online GTs and update Run-3 cosmics MC GTs #38069
• @Pruthvi-ch Corrections for HGCal v17 geometry #38040

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cffcbb/24985/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cffcbb/24985/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3650985
• DQMHistoTests: Total failures: 22
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3650941
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 77920.73400000001 KiB( 49 files compared)
• DQMHistoSizes: changed ( 35034.0,... ): 12986.789 KiB GEM/Digis
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

• 77MiB extra histo memory caused by [GEM] add DQM plots for GE21/GE0 and Fix on massive LogWarnings #37995

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1