Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GEM electronics map to all GTs #38090

Merged
merged 2 commits into from Jun 2, 2022
Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented May 25, 2022

PR description:

This PR

This is a prerequisite of #38062 (i.e. this has to merge first, or at the same time as 38062).

Diff of GTs:

run2_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_v2/123X_dataRun2_v3

run2_data_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_HEfail_v2/123X_dataRun2_HEfail_v3

run2_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_relval_v2/123X_dataRun2_relval_v4

run2_data_promptlike_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_PromptLike_HI_v2/123X_dataRun2_PromptLike_HI_v3

run2_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_HLT_relval_v2/123X_dataRun2_HLT_relval_v3

run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v2/123X_dataRun3_HLT_frozen_v5

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_relval_v5/123X_dataRun3_HLT_relval_v9

run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Express_frozen_v2/123X_dataRun3_Express_frozen_v4

run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_Prompt_frozen_v2/123X_dataRun3_Prompt_frozen_v4

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v5/123X_dataRun3_v7

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v4/123X_dataRun3_relval_v6

phase1_2017_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mc2017_design_v1/123X_mc2017_design_v2

phase1_2017_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mc2017_realistic_v1/123X_mc2017_realistic_v2

phase1_2017_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mc2017cosmics_realistic_deco_v1/123X_mc2017cosmics_realistic_deco_v2

phase1_2017_cosmics_peak
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_mc2017cosmics_realistic_peak_v1/123X_mc2017cosmics_realistic_peak_v2

phase1_2018_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018_design_v2/123X_upgrade2018_design_v4

phase1_2018_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018_realistic_v1/123X_upgrade2018_realistic_v2

phase1_2018_realistic_rd
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018_realistic_RD_v1/123X_upgrade2018_realistic_RD_v3

phase1_2018_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018_realistic_HI_v1/123X_upgrade2018_realistic_HI_v2

phase1_2018_realistic_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018_realistic_HEfail_v1/123X_upgrade2018_realistic_HEfail_v2

phase1_2018_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018cosmics_realistic_deco_v1/123X_upgrade2018cosmics_realistic_deco_v2

phase1_2018_cosmics_peak
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_upgrade2018cosmics_realistic_peak_v1/123X_upgrade2018cosmics_realistic_peak_v2

phase1_2021_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021_design_v1/124X_mcRun3_2021_design_v3

phase1_2021_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021_realistic_v1/124X_mcRun3_2021_realistic_v3

phase1_2021_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021cosmics_realistic_deco_v2/124X_mcRun3_2021cosmics_realistic_deco_v4

phase1_2021_cosmics_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021cosmics_design_deco_v1/124X_mcRun3_2021cosmics_design_deco_v3

phase1_2021_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2021_realistic_HI_v1/124X_mcRun3_2021_realistic_HI_v3

phase1_2023_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2023_realistic_v1/124X_mcRun3_2023_realistic_v3

phase1_2024_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2024_realistic_v1/124X_mcRun3_2024_realistic_v3

phase2_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun4_realistic_v2/124X_mcRun4_realistic_v4

They all contain the new GEM electronics map changes.

Diffs for the snapshotted vs open GTs

PR validation:

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but backport is needed in 12_3_X and 12_4_X too

@tvami
Copy link
Contributor Author

tvami commented May 25, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@tvami
Copy link
Contributor Author

tvami commented May 25, 2022

type gem,ecal

@tvami
Copy link
Contributor Author

tvami commented May 25, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38090/30182

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe9c22/25006/summary.html
COMMIT: 44a5ae4
CMSSW: CMSSW_12_5_X_2022-05-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38090/25006/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe9c22/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe9c22/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4112495
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4112465
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 227 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented May 25, 2022

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label May 25, 2022
@tvami
Copy link
Contributor Author

tvami commented May 31, 2022

unhold

@cmsbuild cmsbuild removed the hold label May 31, 2022
@tvami tvami changed the title Add new GEM electronics map to Run-3 MC and data Add new GEM electronics map to all GTs May 31, 2022
@tvami
Copy link
Contributor Author

tvami commented May 31, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38090/30307

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38090 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Jun 1, 2022

@cmsbuild , please test with #38062

@tvami
Copy link
Contributor Author

tvami commented Jun 1, 2022

@smuzaffar it seems that the bot is struggling with the el8_amd64_gcc10 version, can you maybe have a look what's going on?

@smuzaffar
Copy link
Contributor

@cmsbuild , please test with #38062

@smuzaffar
Copy link
Contributor

@tvami , no idea what had happened. Previous job https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/25141/console was killed by bot itself. May be there were two pending jobs and both killed each other? Anyway, it is running now

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe9c22/25176/summary.html
COMMIT: 2acfd25
CMSSW: CMSSW_12_5_X_2022-06-01-1600/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38090/25176/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe9c22/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fe9c22/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4111521
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4111497
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 227 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Jun 2, 2022

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 2, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants