[MkFitCore] Backport binnor changes to fix 38127.

[osschar]

Backport of #37586 to address #38127.

Floating-point rounding errors led to extending the eta-bin iteration one past the final bin, leading to out-of-bounds array access during seed cleaning.

These calculations has been improved in #37586 so this PR does a limited backport of changes done there, restricting just to binnor.h and the new files radix_sort.h/cc.

Tested on the problematic event provided by @fabiocos.

[cmsbuild]

A new Pull Request was created by @osschar (Matevž Tadel) for CMSSW_12_3_X.

It involves the following packages:

• RecoTracker/MkFitCore (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[fabiocos]

The crash on the problematic event is indeed fixed by this PR

[fabiocos]

... and the whole file can be processed without crashes, thanks for the quick fix.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be198f/25126/summary.html
COMMIT: 71d42e7
CMSSW: CMSSW_12_3_X_2022-05-31-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38151/25126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 420 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627388
• DQMHistoTests: Total failures: 3197
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3624168
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[qliphy]

urgent

[mmusich]

type bug-fix

[mmusich]

type tracking

[jpata]

+reconstruction

• backport of only the binnor-related fixes from [MkFit] Use binnor for seed and hit sorting, remove Ice/ #37586, addresses Crash in MkFit affecting PromptReco #38127
• small fluctutation to tracks and downstream quantities (the validation in the original PR did not reveal any significant physics changes)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
needed for next 12_3, as discussed at today's Ops meeting

[perrotta]

Please be aware that Track reconstruction is not preserved by this fix PR.
Ok for merging it in the urgently needed patch release. However, if any production already started with any previous 12_3_X release this must be taken into account.
@rappoccio , kaori , Jordan , @cms-sw/pdmv-l2