Fix static variable problem in payload inspector code

[Dr15Jones]

PR description:

ServiceRegistry::Operate objects are only ever supposed to be used on the stack.

PR validation:

The unit test testGetPayloadData which showed the problem passed.

Fixes #38141

[Dr15Jones]

The use of static for the ServiceToken isn't great, but I do not believe it will cause a memory problem. (Could be wrong)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38155/30301

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• CondCore/Utilities (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[tvami]

type bugfix

[mmusich]

@cmsbuild , please test

shouldn't it be tested for ASAN_X?

[tvami]

@cmsbuild , please test for CMSSW_12_5_ASAN_X

• good point Marco!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54a9e/25131/summary.html
COMMIT: 19466ae
CMSSW: CMSSW_12_5_X_2022-05-31-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38155/25131/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648315
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3648285
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• test pass
• technical change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54a9e/25135/summary.html
COMMIT: 19466ae
CMSSW: CMSSW_12_5_ASAN_X_2022-05-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38155/25135/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Fix CMS deprecation warnings in L1TriggerConfig/L1ScalesProducers  #38105
• @Dr15Jones Added esConsumes to RecoMuon/TrackerSeedGenerator classes #38094
• @fwyzard Let PFClusterEMEnergyCorrector run without SRB inputs #38081
• @Sam-Harper Fixing Memory Coruption for large histograms in DQMFileSaverPB #38112
• @dinyar Compute muon index bits using idx from dataformat #38035
• @civanch Cleanup geant4 user code #37987
• @Dr15Jones Remove CMS deprecated warnings from L1Trigger/ConfigUtilities #38096
• @Dr15Jones Fix CMS deprecation warnings in L1TriggerConfig/DTTrackFinder #38109
• @mmusich PFDisplacedVertexCandidateFinder: fix deltaPhi cut, don't use std::abs #38080
• @alexsr-98 Implemented new strategy to generate OI seeds for displaced muons #38076
• @emiglior Drop tracker geometry T29 (last with bricked pixels) #38061
• @bsunanda Run3-sim118E Use more the token in accessing collections in SimCalorimetry/HGCalSimProducers #37856
• @cms-tau-pog Remove depreciated DNN-based tau-Ids #38063
• @gartung RecoTracker/MkFitCore: factorize loops to allow gcc -msse3 to vectorize loops #37868
• @thomreis ECAL - GPU unpacker buffer overflow fix #38088

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54a9e/25135/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a54a9e/25135/git-merge-result

RelVals

• 35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

AddOn Tests

• hlt_mc_PIoncmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=HLTrigger/Configuration/CustomConfigs.HLTRECO --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Wed Jun 1 03:53:47 2022-date Wed Jun 1 03:39:14 2022 s - exit: 256
• hlt_mc_PRefcmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=HLTrigger/Configuration/CustomConfigs.HLTRECO --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Wed Jun 1 03:54:51 2022-date Wed Jun 1 03:39:15 2022 s - exit: 256

[qliphy]

@Dr15Jones @tvami There are HLT AddOn failures in ASAN tests above, please have a look.
（adding also @cms-sw/hlt-l2 )

[Dr15Jones]

The failures in the ASAN build are unrelated to this code change. The failures are in GsfElectronProducer and within OscarMTProducer, neither of which use this code change.

[qliphy]

+1