Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to get the PU info from OnlineMetaData stream [12_4_X] #38166

Merged
merged 1 commit into from Jun 2, 2022

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Jun 1, 2022

PR description:

The Pileup information needed for the ML DQM plots was not being accessible as the ScalerStream from which it was taken, has been replaced by MetaDataStream [1]
This PR makes the necessary changes to get the PU information from the correct stream.

PR validation:

The code was validated by running the modified online Ecal DQM configuration and the PU info is accessed as expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38158
Backport needed to ensure availability of the feature in all releases to be used

[1] https://gitlab.cern.ch/cmsos/worksuite/-/commit/c663f7b074b8d9f6e0a12f20d85a397b9ee8a0ef

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/EcalMonitorTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @rchatter, @argiro, @thomreis, @simonepigazzini, @threus, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@pmandrik
Copy link
Contributor

pmandrik commented Jun 1, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c5782/25159/summary.html
COMMIT: 0bc98f5
CMSSW: CMSSW_12_4_X_2022-06-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38166/25159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3669993
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3669963
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 2, 2022

+1

@cmsbuild cmsbuild merged commit a5ef706 into cms-sw:CMSSW_12_4_X Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants