Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clang error in CondTools/RunInfo. #3817

Merged
merged 1 commit into from May 13, 2014
Merged

Fix clang error in CondTools/RunInfo. #3817

merged 1 commit into from May 13, 2014

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2014

Removed unused assignment.

@aledegano
Fix clang error in CondTools/RunInfo.
bc2ae33 
Removed unused assignment.
@ghost ghost added the comparison-pending label May 12, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_1_X.

Fix clang error in CondTools/RunInfo.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ghost ghost added db-pending labels May 12, 2014
ktf
ktf reviewed May 12, 2014
View reviewed changes
CondTools/RunInfo/src/L1TriggerScalerRead.cc
@@ -351,7 +351,6 @@ std::cout<< "table handling " << std::endl;
Itemp.m_date = boost::posix_time::to_iso_extended_string(pt);
std::cout<< " date extracted == " << Itemp.m_date << std::endl;
} else {
Itemp.m_date=="NULL";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an assignment. I suspect what people wanted was:

Itemp.m_date="NULL";

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3817/25/summary.html

@ktf
Copy link
Contributor

ktf commented May 13, 2014

Merging this since it fixes an error in clang and does not change the actual behaviour of the code. Code is probably broken in any case so please fix it in a subsequent PR.

ktf added a commit that referenced this pull request May 13, 2014
@ktf
Merge pull request #3817 from degano/fix_clangerr_condtoolsruninfo_71X
67fd3a9 
Clang -- Fix error in CondTools/RunInfo.
@ktf ktf merged commit 67fd3a9 into cms-sw:CMSSW_7_1_X May 13, 2014
@ghost ghost deleted the fix_clangerr_condtoolsruninfo_71X branch May 15, 2014 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending db-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmsbuild @ktf @aledegano