Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigBuilder: raise an exception if the name of the alca producer exceeds the DBS schema constraints #38189

Merged
merged 1 commit into from Jun 9, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 1, 2022

PR description:

This PR is half-provocative, inspired by the discussion at https://cms-talk.web.cern.ch/t/alcaprompt-datasets-not-loaded-in-dbs/11146.
Since this is the second time it happens in the CMS history (see also this old hypernew) there should be a way to stop developers to create running configurations that must be abandoned because of the DBS database schema limitations only after these are put into production.
Perhaps this could be generalized to other steps too.

PR validation:

Tried using an alca name longer than 31 chars and obtained the exception:

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/nweek-02735/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-05-30-2300/bin/slc7_amd64_gcc10/cmsDriver.py", line 56, in <module>
    run()
  File "/cvmfs/cms-ib.cern.ch/nweek-02735/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-05-30-2300/bin/slc7_amd64_gcc10/cmsDriver.py", line 28, in run
    configBuilder.prepare()
  File "/build/musich/massiverename/checkConfigBuilder/CMSSW_12_5_X_2022-06-01-1100/src/Configuration/Applications/python/ConfigBuilder.py", line 2167, in prepare
    self.addStandardSequences()
  File "/build/musich/massiverename/checkConfigBuilder/CMSSW_12_5_X_2022-06-01-1100/src/Configuration/Applications/python/ConfigBuilder.py", line 790, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = '+'.join(stepSpec))
  File "/build/musich/massiverename/checkConfigBuilder/CMSSW_12_5_X_2022-06-01-1100/src/Configuration/Applications/python/ConfigBuilder.py", line 1282, in prepare_ALCA
    raise Exception("The following alca "+str(alca)+" name (with length "+str(len(alca))+" chars) cannot be accepted because it exceeds the DBS constraints on the length of the name of the ALCARECOs producers ("+str(MAXLEN)+")!")
Exception: The following alca PromptCalibProdSiPixelLorentzAngle name (with length 34 chars) cannot be accepted because it exceeds the DBS constraints on the length of the name of the ALCARECOs producers (31)!

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38189/30341

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a1e75/25188/summary.html
COMMIT: 37a9df6
CMSSW: CMSSW_12_5_X_2022-06-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38189/25188/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 1001.01001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7+ALCAHARVD8/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5+ALCAHARVD7+ALCAHARVD8.log

@mmusich
Copy link
Contributor Author

mmusich commented Jun 2, 2022

as expected this fails.
Once #38186 is merged, this should succeed.

@tvami
Copy link
Contributor

tvami commented Jun 2, 2022

@cmsbuild , please test with #38186

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a1e75/25196/summary.html
COMMIT: 37a9df6
CMSSW: CMSSW_12_5_X_2022-06-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38189/25196/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3649923
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3649893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2022

@cms-sw/operations-l2 I would be glad to know your opinion about this.

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d747a85 into cms-sw:master Jun 9, 2022
@mmusich mmusich changed the title [RFC] ConfigBuilder: raise an exception if the name of the alca producer exceeds the DBS schema constraints ConfigBuilder: raise an exception if the name of the alca producer exceeds the DBS schema constraints Jun 9, 2022
@mmusich mmusich deleted the ConfigBuilderMaxAlCaLength branch June 9, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants