[12.4.X] protect ALCARECOSiStripCalCosmicsNano for missing tracks (when Tracker DCS is OFF)

[mmusich]

backport of #38213

PR description:

Title says it all.
The problem arises because the input events for SiStripCalCosmics (which is the input for this workflow)

cmssw/Calibration/TkAlCaRecoProducers/python/ALCARECOSiStripCalCosmicsNano_cff.py

Line 18 in cb55e64

ALCARECOSiStripCalCosmicsNanoCalibTracks = CalibrationTracks.clone(src=cms.InputTag("ALCARECOSiStripCalCosmics"))

are DSC-filtered:

cmssw/Calibration/TkAlCaRecoProducers/python/ALCARECOSiStripCalCosmics_cff.py

Lines 13 to 19 in cb55e64

	import CalibTracker.SiStripCommon.SiStripDCSFilter_cfi
	DCSStatusForSiStripCalCosmics = CalibTracker.SiStripCommon.SiStripDCSFilter_cfi.siStripDCSFilter.clone(
	DetectorType = cms.vstring('TIBTID','TOB','TECp','TECm'),
	ApplyFilter = cms.bool(True),
	AndOr = cms.bool(True),
	DebugOn = cms.untracked.bool(False)
	)

but the SiStripCalCosmicsNano is not, hence in circulating beams situation (when TK HV is off) there are no input tracks, but the producer is run nonetheless.

Resolves problem described at https://cms-talk.web.cern.ch/t/failure-at-tier0-of-sistripcalcosmicsnano/11186.

PR validation:

Private.
After the fix, successfully run the following command:

python3 Configuration/DataProcessing/test/RunPromptReco.py --scenario cosmicsEra_Run3 --reco --global-tag 123X_dataRun3_Prompt_v8 --lfn=root://eoscms.cern.ch//eos/cms/tier0/store/data/Run2022A/Cosmics/RAW/v1/000/352/705/00000/636e0528-de8a-4acd-bd7c-e99bf0c4aa27.root --alcareco SiStripCalCosmicsNano

using the problematic input file specified in the cmsTalk posting

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38213

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

• Calibration/TkAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @threus, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from protect ALCARECOSiStripCalCosmicsNano for missing tracks (when Tracker DCS is OFF) #38213

[mmusich]

type trk, bug-fix

[mmusich]

test parameters:

• workflows = 7.2, 7.21, 7.22, 7.23, 7.24, 7.3, 7.4, 134.813, 136.733, 138.1, 138.2

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8067d9/25227/summary.html
COMMIT: e6dc204
CMSSW: CMSSW_12_4_X_2022-06-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38214/25227/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/136.733_RunCosmics2016B+RunCosmics2016B+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8067d9/7.24_Cosmics_UP21_0T+Cosmics_UP21_0T+DIGICOS_UP21_0T+RECOCOS_UP21_0T+ALCACOS_UP21_0T+HARVESTCOS_UP21_0T

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 60
• DQMHistoTests: Total histograms compared: 3981733
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3981703
• DQMHistoTests: Total skipped: 28
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 59 files compared)
• Checked 254 log files, 45 edm output root files, 60 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass
• private tests with the problematic run pass, too

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1