ECAL - Fix ECAL static analyzer issues in CalibCalorimetry and CondFormats packages #38235
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38235/30384
|
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi @thomreis can you confirm my understanding that none of this is needed for the data taking? Thanks! Please mention in the PR description that there is no backport needed. |
|
None of this is needed for data taking. No backport is needed. |
|
Thanks for confirming! |
| if (EEDetId::validDetId(ix, iy, iz)) { | ||
| EEDetId cell(ix, iy, iz); | ||
| return cell; | ||
| } else { | ||
| std::cout << "Null coordinates = " << ix << "," << iy << "," << iz << std::endl; |
There was a problem hiding this comment.
cout should be replaced with the relevant MsgLogger function, maybe for another PR tho?
| TEcnaParPaths* pCnaParPaths, | ||
| TEcnaParCout* pCnaParCout, | ||
| TEcnaParEcal* pEcal, | ||
| TEcnaNumbering* pEcalNumbering) { | ||
| // std::cout << "[Info Management] CLASS: TEcnaWrite. CREATE OBJECT: this = " << this << std::endl; |
There was a problem hiding this comment.
Please remove commented out code
|
@cmsbuild , please test |
|
@thomreis if you prefer I'm fine approving this PR as it is, and you can have a dedicated PR for |
|
Hi @tvami, yes the purpose of this PR was to address SA issues. Code cleaning can be done in a future PR. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3636e/25257/summary.html Comparison SummarySummary:
|
|
@thomreis there is a few more things reported by the SA: |
|
Yes, the PR does not fix all of the SA issues. Some of them are related to HCAL, the non-const global static variables are from ROOT macros and the non-const static variables I do not really know how to fix without touching the functionality of the code. |
|
+1
|
cmsbuild
added
alca-approved
db-approved
fully-signed
and removed
alca-pending
db-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Fixes some ECAL related static analyzer issues in CalibCalorimetry and CondFormats packages
PR validation:
Passes matrix tests.