[Backport] Turning on GE21 digis to be unpacked for monitoring [12_3_X] #38256

yeckang · 2022-06-06T13:29:11Z

PR description:

GE 21 demonstrator has installed in P5. And GEM group wants to monitor the demonstrator with DQM using digis.
GEM packer and unpacker are updated for using GEMChMap to unpack the data from GE21 demonstrator.
Generating RecHits with GE21 is turned off, so the demonstrator doesn't affect muons upstream.

PR validation:

The code format has applied with scram build code-format and scram build code-checks.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is backport of [GEM] GEM packer-unpacker update for GEMChMap #38062 and Turn on GEMDigis and turn off GEMRecHits for GE2/1 demonstrator #38119

@jshlee @watson-ij

Update GEM Digi data formats Fix bug in writing GEMChMap

Need to adjust GEM L1T DQM to account for GE2/1 digis

cmsbuild · 2022-06-06T13:29:41Z

A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_12_3_X.

It involves the following packages:

CondFormats/GEMObjects (db)
DQM/GEM (dqm)
DQM/L1TMonitor (dqm)
DataFormats/GEMDigi (upgrade, simulation)
EventFilter/GEMRawToDigi (reconstruction)
RecoLocalMuon/GEMRecHit (upgrade, reconstruction)

@malbouis, @civanch, @ggovi, @clacaputo, @emanueleusai, @mdhildreth, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @pmandrik, @slava77, @jpata, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @jshlee, @bellan, @jhgoh, @eyigitba, @Martin-Grunewald, @missirol, @watson-ij, @trtomei, @mmusich, @rovere, @beaucero, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Turn on GEMDigis and turn off GEMRecHits for GE2/1 demonstrator #38119

tvami · 2022-06-06T13:30:59Z

backport of #38062

tvami · 2022-06-06T13:31:29Z

backport of #38119

tvami · 2022-06-06T13:31:56Z

type gem

tvami · 2022-06-06T13:33:30Z

@cmsbuild , please test

cmsbuild · 2022-06-06T15:33:20Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588ad1/25302/summary.html
COMMIT: f90b8c3
CMSSW: CMSSW_12_3_X_2022-06-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38256/25302/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

138.4

----- Begin Fatal Exception 06-Jun-2022 16:48:44 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 346512
   [1] Calling method for module GEMRawToDigiModule/'muonGEMDigis'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

7.3

----- Begin Fatal Exception 06-Jun-2022 16:49:03 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module GEMDigiToRawModule/'gemPacker'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 06-Jun-2022 16:50:42 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 346512
   [1] Calling method for module GEMRawToDigiModule/'unpackGEM'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

11.011.0_MinBias+MinBiasINPUT+DIGI+RECOMIN+HARVEST+ALCAMIN/step2_MinBias+MinBiasINPUT+DIGI+RECOMIN+HARVEST+ALCAMIN.log
9.09.0_Higgs200ChargedTaus+Higgs200ChargedTausINPUT+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTausINPUT+DIGI+RECO+HARVEST.log
10.010.0_ADDMonoJet_d3MD3+ADDMonoJet_d3MD3INPUT+DIGI+RECO+HARVEST/step2_ADDMonoJet_d3MD3+ADDMonoJet_d3MD3INPUT+DIGI+RECO+HARVEST.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 06-Jun-2022 16:33:44 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module GEMDigiToRawModule/'gemPacker'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 06-Jun-2022 16:33:45 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module GEMDigiToRawModule/'gemPacker'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 06-Jun-2022 16:33:47 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 1
   [1] Calling method for module GEMDigiToRawModule/'gemPacker'
Exception Message:
No "GEMChMapRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

tvami · 2022-06-06T15:37:26Z

@cmsbuild , please test with #38251

cmsbuild · 2022-06-06T19:29:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-588ad1/25311/summary.html
COMMIT: f90b8c3
CMSSW: CMSSW_12_3_X_2022-06-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38256/25311/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3628978
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3628948
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 52.72999999999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 5.273 KiB L1TEMU/L1TdeGEMTPG
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-06-06T19:47:21Z

+db

the IB are running fine with the master version of this PR

srimanob · 2022-06-07T03:43:13Z

+Upgrade

Backport PR.

jpata · 2022-06-07T07:17:21Z

+reconstruction

backport of [GEM] GEM packer-unpacker update for GEMChMap #38062, Turn on GEMDigis and turn off GEMRecHits for GE2/1 demonstrator #38119
no reco changes

tvami · 2022-06-07T12:35:23Z

@civanch can you please sign this backport PR?

civanch · 2022-06-07T15:18:07Z

+1

tvami · 2022-06-07T15:20:38Z

urgent

as we discussed at ORP

qliphy · 2022-06-07T15:39:58Z

+1

qliphy · 2022-06-07T15:40:38Z

sorry I bypassed @cms-sw/dqm-l2 by accident. Please let me know if @cms-sw/dqm-l2 you have any concern

pmandrik · 2022-06-08T14:16:55Z

+1

cmsbuild · 2022-06-08T14:17:17Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

yeckang added 2 commits June 3, 2022 18:55

Update GEM packer-unpacker and GEM/DQM for GEMChMap

75311f7

Update GEM Digi data formats Fix bug in writing GEMChMap

Turn ON GEMDigis for GE2/1, turn OFF GEMRecHits for GE2/1

f90b8c3

Need to adjust GEM L1T DQM to account for GE2/1 digis

cmsbuild added this to the CMSSW_12_3_X milestone Jun 6, 2022

cmsbuild added db-pending dqm-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending upgrade-pending labels Jun 6, 2022

cmsbuild added the backport-ok label Jun 6, 2022

cmsbuild added the gem label Jun 6, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 6, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 6, 2022

cmsbuild added requires-external tests-started and removed tests-rejected labels Jun 6, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 6, 2022

cmsbuild added db-approved and removed db-pending labels Jun 6, 2022

tvami mentioned this pull request Jun 6, 2022

[12_3_X] Add new GEM electronics map to all GTs #38251

Merged

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 7, 2022

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 7, 2022

cmsbuild added simulation-approved and removed simulation-pending labels Jun 7, 2022

cmsbuild added the urgent label Jun 7, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 7, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 8, 2022

cmsbuild merged commit 72e6169 into cms-sw:CMSSW_12_3_X Jun 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport] Turning on GE21 digis to be unpacked for monitoring [12_3_X] #38256

[Backport] Turning on GE21 digis to be unpacked for monitoring [12_3_X] #38256

yeckang commented Jun 6, 2022

cmsbuild commented Jun 6, 2022 •

edited

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

cmsbuild commented Jun 6, 2022

tvami commented Jun 6, 2022

cmsbuild commented Jun 6, 2022

tvami commented Jun 6, 2022

srimanob commented Jun 7, 2022

jpata commented Jun 7, 2022

tvami commented Jun 7, 2022

civanch commented Jun 7, 2022

tvami commented Jun 7, 2022

qliphy commented Jun 7, 2022

qliphy commented Jun 7, 2022

pmandrik commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

[Backport] Turning on GE21 digis to be unpacked for monitoring [12_3_X] #38256

[Backport] Turning on GE21 digis to be unpacked for monitoring [12_3_X] #38256

Conversation

yeckang commented Jun 6, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 6, 2022 • edited

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

tvami commented Jun 6, 2022

cmsbuild commented Jun 6, 2022

RelVals

RelVals-INPUT

AddOn Tests

tvami commented Jun 6, 2022

cmsbuild commented Jun 6, 2022

Comparison Summary

tvami commented Jun 6, 2022

srimanob commented Jun 7, 2022

jpata commented Jun 7, 2022

tvami commented Jun 7, 2022

civanch commented Jun 7, 2022

tvami commented Jun 7, 2022

qliphy commented Jun 7, 2022

qliphy commented Jun 7, 2022

pmandrik commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

cmsbuild commented Jun 6, 2022 •

edited