Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECAL TPG emulator discrepancy for saturated strips #38272

Merged

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Jun 7, 2022

PR description:

This PR fixes a discrepancy between the ECAL frontend trigger primitive formation and the emulator code in CMSSW for saturated strips.

In the frontend hardware, after the filter and peak-finder blocks, the even and odd amplitude outputs are checked for saturation and truncated to 12 bits. After that, the even and odd amplitudes are compared with 12 bits precision (only in the EB Fenix TCP board) to determine the double weights flags.

In the emulator the saturation was not checked at that stage and therefore the even/odd comparison was performed with 18 bits precision.

This was causing data/emulator discrepancy in the saturated TPs observed during double weights test with splashes events in April.

In the frontend hardware after the sliding window applied in the peak-finder block the output
of each filter is saturated at 12bits. Then, the even and odd outputs are compared.

In the emulator the saturation was not checked and the odd and even amplitudes were compared at 18bits.
This PR fixes the problem.
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jun 7, 2022
@valsdav valsdav changed the title Fixing ECAL TPG emulator discrepancy for saturated strips Fix ECAL TPG emulator discrepancy for saturated strips Jun 7, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38272/30423

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

A new Pull Request was created by @valsdav (Davide Valsecchi) for master.

It involves the following packages:

  • SimCalorimetry/EcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @rovere, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80dcf/25355/summary.html
COMMIT: b751607
CMSSW: CMSSW_12_5_X_2022-06-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38272/25355/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3652078
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3652054
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants