New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ECAL TPG emulator discrepancy for saturated strips #38272
Fix ECAL TPG emulator discrepancy for saturated strips #38272
Conversation
In the frontend hardware after the sliding window applied in the peak-finder block the output of each filter is saturated at 12bits. Then, the even and odd outputs are compared. In the emulator the saturation was not checked and the odd and even amplitudes were compared at 18bits. This PR fixes the problem.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38272/30423
|
A new Pull Request was created by @valsdav (Davide Valsecchi) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d80dcf/25355/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes a discrepancy between the ECAL frontend trigger primitive formation and the emulator code in CMSSW for saturated strips.
In the frontend hardware, after the filter and peak-finder blocks, the even and odd amplitude outputs are checked for saturation and truncated to 12 bits. After that, the even and odd amplitudes are compared with 12 bits precision (only in the EB Fenix TCP board) to determine the double weights flags.
In the emulator the saturation was not checked at that stage and therefore the even/odd comparison was performed with 18 bits precision.
This was causing data/emulator discrepancy in the saturated TPs observed during double weights test with splashes events in April.