Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Introduce TkAlJetHT #38297

Merged
merged 2 commits into from Jun 10, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 9, 2022

backport of #38254

PR description:

In PR #27307 the TkAlMinBias ALCARECO flavour was added to the JetHT dataset in the autoAlCa file, in order to have it produced for the Run-2 Ultra-Legacy reprocessing.
Operational experience with it has indicated that the resulting PDs are too large to be able tocomfortably distribute them at the target T2s, so that workflow is superseded by adding a new producer TkAlJetHT tailored to be used on the JetHT sample, which contains a prescale of 10 (1 event of ten input events will be processed). This should alleviate the output size and the burden on disk and operation teams.
This is proposed in this PR. As a new eventSetupPathsKey (= TkAlJetHTHLT) is introduced here a new set of AlCaRecoTriggerBitsRcd tags:

  • AlCaRecoHLTpaths_2017_offline_v6 which is a superset of the production tag AlCaRecoHLTpaths_2017_offline_v4, but will all IOVs substituted by new payloads adding the TkAlJetHT key (used in auto:run2_data*)
  • AlCaRecoHLTpaths_2021_offline_v2 which is a superset of the production tag AlCaRecoHLTpaths_2021_offline_v1, but will all IOVs substituted by new payloads adding the TkAlJetHT key (used in auto:run3_data*)
Global Tag Changes:

run2_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_v4/123X_dataRun2_v3

run2_data_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_HEfail_v4/123X_dataRun2_HEfail_v3

run2_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_relval_v5/123X_dataRun2_relval_v4

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v9/123X_dataRun3_v7

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v8/123X_dataRun3_relval_v6

PR validation:

Run successfully the Tier-0 testing workflow:

runTheMatrix.py -l 1000.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38254

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/StandardSequences (operations)
  • DQMOffline/Alignment (dqm)

@perrotta, @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @francescobrivio, @davidlange6 can you please review it and eventually sign? Thanks.
@pakhotin, @fabiocos, @adewit, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @tocheng, @lecriste, @tlampen, @mmusich, @mtosi, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title [12.4.X] Introduce TkAlJetHT [12.3.X] Introduce TkAlJetHT Jun 9, 2022
@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

Hi Marco,

I may have misunderstood
"Not a backport but it will need to be backported (at least to 12.4.X)"
in the master PR. I understood this that this PR to 12_3_X is not very crucial. And that's why the GTs we created started with 12_4_X.

The spurious changes you see are there due to #38295 not being merged yet.

Anyway, can you elaborate a bit on the need of this for 12_3_X? We'd also need to change the AlCaRECO matrix and the T0 config... so I'm wondering if we can let this go for 12_3_X?

@mmusich
Copy link
Contributor Author

mmusich commented Jun 9, 2022

Anyway, can you elaborate a bit on the need of this for 12_3_X? We'd also need to change the AlCaRECO matrix and the T0 config...

It would be better to do it also for 12.3.X as it targets the 13.6TeV collisions in general. It would be quite bad to have to mix different dataset names due to the era. Actually I asked your @cms-sw/alca-l2 colleagues about it and they told me to do the backport, I take you don't talk among yourselves :D ?
bottom line, please provide new GlobalTags

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

I take you don't talk among yourselves :D ?

Not when I sleep :D

@mmusich
Copy link
Contributor Author

mmusich commented Jun 9, 2022

Not when I sleep :D

before commenting on PRs you might want to synch first :D

@malbouis
Copy link
Contributor

malbouis commented Jun 9, 2022

@mmusich we have created new GTs for this PR.
The differences you saw above were due to the changes introduced in PR #38295
We will merge the GT changes from above PR into this one, if it is OK with you. If so, would you please also kindly update the description of this PR to take these differences into account?

Here are the new GTs and their differences wrt to the previous ones:
run2_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_v4/123X_dataRun2_v3

run2_data_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_HEfail_v4/123X_dataRun2_HEfail_v3

run2_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun2_relval_v5/123X_dataRun2_relval_v4

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v9/123X_dataRun3_v7

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v8/123X_dataRun3_relval_v6

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

Pull request #38297 was updated. @perrotta, @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @francescobrivio, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 9, 2022

@malbouis

We will merge the GT changes from above PR into this one, if it is OK with you. If so, would you please also kindly update the description of this PR to take these differences into account?

done for both points. Thanks

@mmusich
Copy link
Contributor Author

mmusich commented Jun 9, 2022

@cmsbuild, please test

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

type trk

@cmsbuild cmsbuild added the trk label Jun 9, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cc7ce/25393/summary.html
COMMIT: ae11863
CMSSW: CMSSW_12_3_X_2022-06-09-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38297/25393/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3629068
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3629031
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1810.51 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

1 similar comment
@emanueleusai
Copy link
Member

+1

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 4c2aa55 into cms-sw:CMSSW_12_3_X Jun 10, 2022
@mmusich mmusich deleted the addTkAlJetHT_12_3_X branch June 10, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants