Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] HCAL GPU-CPU Comparison for the Online DQM #38318

Merged
merged 2 commits into from Jun 13, 2022

Conversation

pmandrik
Copy link
Contributor

PR description:

Adding a new DQM client to produce GPU-CPU comparison plots for online DQM, together with a small fix of 2D plot to show profiling instead of accumulating rechits.
Then fix required GPU stream name to start with "stream".

PR validation:

Original PRs were tested at P5 playback. This PR is cherry-picked from original PRs below.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38142 and #38257

Backport of PR cms-sw#38142: HCAL GPU client for the Online DQM
[12_3_X] Fix streamLabel name in hcalgpu_dqm_sourceclient-live_cfg.p
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pmandrik for CMSSW_12_4_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@DryRun, @battibass, @abdoulline, @bsunanda, @francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@pmandrik
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4527/25429/summary.html
COMMIT: 785741e
CMSSW: CMSSW_12_4_X_2022-06-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38318/25429/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4527/25429/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea4527/25429/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3679963
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3679939
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 13, 2022

+1

@cmsbuild cmsbuild merged commit e576d09 into cms-sw:CMSSW_12_4_X Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants