[12_4_X] Fix EMTF Run 3 CSC pattern calculation

[eyigitba]

PR description:

In PrimitiveConversion we use CreateCSCDetId to calculate the equivalent Run 2 pattern ID for Run 3 CSC TPs. This was being called before other information about the CSC hit was set, so it was not working properly before. Since Run 3 CSC TPs are not enabled in the emulator yet, this wasn't caught earlier.

I moved the code a couple of lines down and now it gets called after we set endcap, station, ring, and chamber informations to the hit. It now functions as it should.

No changes are epxected until we enable Run 3 CSC TPs

PR validation:

Validated with local repository after enabling Run 3 CSC TPs and the run 2 pattern IDs are now set correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38319

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_12_4_X.

It involves the following packages:

• L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e992bf/25441/summary.html
COMMIT: 10921df
CMSSW: CMSSW_12_4_X_2022-06-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38320/25441/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3679963
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3679933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1