[12_4_X] Put sampic subdet id behind the era modifier #38365

francescobrivio · 2022-06-14T10:12:15Z

PR description:

Backport of #38338 and #38366
This PR puts the totemTimingDetId subdetector behind the era modifier. For Run3 subdet=5, for 2016,2017,2018 subdet=6

PR validation:

PR was tested with 136.8562 which was previously failing.

Backport:

Backport of #38338 and #38366

FYI @ChrisMisan

cmsbuild · 2022-06-14T10:12:38Z

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

CalibPPS/ESProducers (alca)
EventFilter/CTPPSRawToDigi (reconstruction)

@malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @tocheng, @Martin-Grunewald, @missirol, @grzanka, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from [Fix] Put sampic subdet id behind the era modifier #38338

francescobrivio · 2022-06-14T10:13:25Z

backport of #38338

francescobrivio · 2022-06-14T10:13:58Z

test parameters:

workflows = 136.8562

francescobrivio · 2022-06-14T10:14:25Z

@cmsbuild please test

tvami · 2022-06-14T11:01:14Z

type ctpps

EventFilter/CTPPSRawToDigi/python/ctppsRawToDigi_cff.py

cmsbuild · 2022-06-14T14:30:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78335/25507/summary.html
COMMIT: c56d86b
CMSSW: CMSSW_12_4_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38365/25507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8562 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 371 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3680359
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3680329
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 211 log files, 48 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-06-14T15:07:35Z

Pull request #38365 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

tvami · 2022-06-14T15:11:21Z

@cmsbuild , please test

francescobrivio · 2022-06-14T15:38:01Z

With the current commits I see this error (log here):

----- Begin Fatal Exception 14-Jun-2022 17:27:49 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2022-06-14T16:30:59Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78335/25519/summary.html
COMMIT: deb4a01
CMSSW: CMSSW_12_4_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38365/25519/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testExpressPPSAlCaRecoProducer had ERRORS
---> test testPromptPPSAlCaRecoProducer had ERRORS
---> test testExpressPPSAlCaRecoOutput had ERRORS
---> test testPromptPPSAlCaRecoOutput had ERRORS
and more ...

RelVals

4.22

----- Begin Fatal Exception 14-Jun-2022 17:25:16 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

138.4

----- Begin Fatal Exception 14-Jun-2022 17:26:09 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 14-Jun-2022 17:26:45 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
134.813134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_Fake

----- Begin Fatal Exception 14-Jun-2022 17:28:54 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 14-Jun-2022 17:28:55 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake2

----- Begin Fatal Exception 14-Jun-2022 17:29:02 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing ESSource: class=TotemDAQMappingESSourceXML label='totemDAQMappingESSourceXML_TimingDiamond'
Exception Message:
MissingParameter: Parameter 'sampicSubDetId' not found.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2022-06-15T07:07:28Z

Pull request #38365 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

francescobrivio · 2022-06-15T07:09:06Z

@cmsbuild please test

tvami · 2022-06-15T09:27:33Z

There is a failure in reading one of the files,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78335/25531/runTheMatrixINPUT-results/1365.0_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
it's obviously not connected to this change. Do we need to re-trigger tests? To me if this is the only problem, we should just sign it

cmsbuild · 2022-06-15T11:10:03Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a78335/25531/summary.html
COMMIT: 0ae485b
CMSSW: CMSSW_12_4_X_2022-06-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38365/25531/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

1365.01365.0_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_BuToJpsiK_13+BuToJpsiK_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8562 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 351 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3680359
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3680329
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 211 log files, 48 edm output root files, 50 DQM output files
TriggerResults: no differences found

tvami · 2022-06-15T11:49:55Z

+alca

test pass, see the caveat in [12_4_X] Put sampic subdet id behind the era modifier #38365 (comment)

clacaputo · 2022-06-15T13:33:02Z

+reconstruction

backport in line with the original PRs
test pass, see the caveat in [12_4_X] Put sampic subdet id behind the era modifier #38365 (comment)

cmsbuild · 2022-06-15T13:33:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-15T19:47:19Z

+1

For CMSSW_12_4_0

perrotta · 2022-06-15T19:47:40Z

merge

put sampic subdet id behind the era modifier

c56d86b

cmsbuild added this to the CMSSW_12_4_X milestone Jun 14, 2022

cmsbuild added alca-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 14, 2022

francescobrivio mentioned this pull request Jun 14, 2022

[Fix] Put sampic subdet id behind the era modifier #38338

Merged

cmsbuild added the backport-ok label Jun 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2022

cmsbuild added the ctpps label Jun 14, 2022

tvami reviewed Jun 14, 2022

View reviewed changes

EventFilter/CTPPSRawToDigi/python/ctppsRawToDigi_cff.py Outdated Show resolved Hide resolved

perrotta reviewed Jun 14, 2022

View reviewed changes

EventFilter/CTPPSRawToDigi/python/ctppsRawToDigi_cff.py Outdated Show resolved Hide resolved

EventFilter/CTPPSRawToDigi/python/ctppsRawToDigi_cff.py Outdated Show resolved Hide resolved

ChrisMisan mentioned this pull request Jun 14, 2022

Make sampicSubDetId a tracked parameter #38366

Merged

cmsbuild added tests-approved and removed tests-started labels Jun 14, 2022

Make sampicSubDetId a tracked parameter

deb4a01

cmsbuild added tests-pending and removed tests-approved labels Jun 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 14, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 14, 2022

addi missing sampicSubDetId instances in the PPS cfg

0ae485b

cmsbuild added tests-pending and removed tests-rejected labels Jun 15, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 15, 2022

cmsbuild added alca-approved and removed alca-pending labels Jun 15, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jun 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 15, 2022

cmsbuild merged commit ccd5266 into cms-sw:CMSSW_12_4_X Jun 15, 2022

francescobrivio deleted the alca-PPS_eramodifier_12_4_X branch June 16, 2022 08:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12_4_X] Put sampic subdet id behind the era modifier #38365

[12_4_X] Put sampic subdet id behind the era modifier #38365

francescobrivio commented Jun 14, 2022 •

edited

cmsbuild commented Jun 14, 2022 •

edited

francescobrivio commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

tvami commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

tvami commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 15, 2022

francescobrivio commented Jun 15, 2022

tvami commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

tvami commented Jun 15, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

perrotta commented Jun 15, 2022

[12_4_X] Put sampic subdet id behind the era modifier #38365

[12_4_X] Put sampic subdet id behind the era modifier #38365

Conversation

francescobrivio commented Jun 14, 2022 • edited

PR description:

PR validation:

Backport:

cmsbuild commented Jun 14, 2022 • edited

francescobrivio commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

tvami commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

Comparison Summary

cmsbuild commented Jun 14, 2022

tvami commented Jun 14, 2022

francescobrivio commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Jun 15, 2022

francescobrivio commented Jun 15, 2022

tvami commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

RelVals-INPUT

Comparison Summary

tvami commented Jun 15, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

perrotta commented Jun 15, 2022

francescobrivio commented Jun 14, 2022 •

edited

cmsbuild commented Jun 14, 2022 •

edited