improve Tracker geometry comparison plot in Payload Inspector

[mmusich]

PR description:

Title says it all. Mostly show the Euler angle value difference as 0 if it is within 2 parts per ten million of 2π to avoid altering the overall scale.

PR validation:

Private. Run the script:

elements=(X Y Z Alpha Beta Gamma)

for i in "${elements[@]}"
do
    echo "Processing: $i coordinate"

    getPayloadData.py  \
	--plugin pluginTrackerAlignment_PayloadInspector \
	--plot plot_TrackerAlignmentCompare${i}TwoTags \
	--tag fromGeometry  \
	--tagtwo fromGT \
	--time_type Run \
	--iovs '{"start_iov": "1", "end_iov": "1"}' \
	--iovstwo '{"start_iov": "1", "end_iov": "1"}' \
	--db sqlite_file:toComapre.db \
	--test;

    mv *.png $W_DIR/compareFromGeometry/TrackerAlignmentCompare${i}.png

done

with and without this PR and obtained the following sets of plots:

• vanilla release: link
• this branch: link

See for example:

Vanilla release	This branch

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38369/30555

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/AlignmentPlugins (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6e8f1/25515/summary.html
COMMIT: 1f09f55
CMSSW: CMSSW_12_5_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38369/25515/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659074
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3659038
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• trusting private scripts validation

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@tvami

trusting private scripts validation

FYI: actually it is run in the unit tests, see log

[tvami]

Oh great! Thanks!

[qliphy]

+1