Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X]Restore sampicSubDetId backward compatibility #38376

Merged
merged 2 commits into from Jun 20, 2022

Conversation

ChrisMisan
Copy link
Contributor

PR description:

This is a backport of #38338 and #38366

PR validation:

PR was tested with 136.8562 which was previously failing.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_3_X.

It involves the following packages:

  • CalibPPS/ESProducers (alca)
  • EventFilter/CTPPSRawToDigi (reconstruction)

@malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@fabferro, @tocheng, @Martin-Grunewald, @missirol, @grzanka, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 15, 2022

type ctpps

@tvami
Copy link
Contributor

tvami commented Jun 15, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Jun 15, 2022

@cmsbuild , please abort

@tvami
Copy link
Contributor

tvami commented Jun 15, 2022

test parameters:

  • workflows = 136.8562

@tvami
Copy link
Contributor

tvami commented Jun 15, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f729ea/25537/summary.html
COMMIT: d93559f
CMSSW: CMSSW_12_3_X_2022-06-15-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38376/25537/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8562 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 413 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630260
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 208 log files, 48 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

yuanchao commented Jun 19, 2022

+1

A backport of #38338 and #38366 by adding back sampicSubDetId.

  • SA checks and matrix wf tests passed
  • no significant difference seen in DQM

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4ae366 into cms-sw:CMSSW_12_3_X Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants